Code cleanup in contexts

[lttng-ust.git] / liblttng-ust / lttng-context-perf-counters.c

diff --git a/liblttng-ust/lttng-context-perf-counters.c b/liblttng-ust/lttng-context-perf-counters.c
index dbb1e6b1dcf368d339053ba1c199f90347007e79..4816f89b5a4a536e4cc2741e6e5d658379692baf 100644 (file)
--- a/liblttng-ust/lttng-context-perf-counters.c
+++ b/liblttng-ust/lttng-context-perf-counters.c
@@ -20,6 +20,7 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#define _LGPL_SOURCE
 #include <sys/types.h>
 #include <unistd.h>
 #include <string.h>
@@ -28,7 +29,6 @@
 #include <stdbool.h>
 #include <sys/mman.h>
 #include <sys/syscall.h>
-#include <linux/perf_event.h>
 #include <lttng/ust-events.h>
 #include <lttng/ust-tracer.h>
 #include <lttng/ringbuffer-config.h>
@@ -39,6 +39,7 @@
 #include <urcu/ref.h>
 #include <usterr-signal-safe.h>
 #include <signal.h>
+#include "perf_event.h"
 #include "lttng-tracer-core.h"
 
 /*
@@ -108,6 +109,15 @@ uint64_t rdpmc(unsigned int counter)
        return low | ((uint64_t) high) << 32;
 }
 
+static
+bool has_rdpmc(struct perf_event_mmap_page *pc)
+{
+       if (caa_unlikely(!pc->cap_bit0_is_deprecated))
+               return false;
+       /* Since Linux kernel 3.12. */
+       return pc->cap_user_rdpmc;
+}
+
 static
 uint64_t arch_read_perf_counter(
                struct lttng_perf_counter_thread_field *thread_field)
@@ -124,7 +134,7 @@ uint64_t arch_read_perf_counter(
                cmm_barrier();
 
                idx = pc->index;
-               if (caa_likely(pc->cap_user_rdpmc && idx)) {
+               if (caa_likely(has_rdpmc(pc) && idx)) {
                        int64_t pmcval;
 
                        pmcval = rdpmc(idx - 1);
@@ -149,7 +159,7 @@ int arch_perf_keep_fd(struct lttng_perf_counter_thread_field *thread_field)
 
        if (!pc)
                return 0;
-       return !pc->cap_user_rdpmc;
+       return !has_rdpmc(pc);
 }
 
 #else
@@ -205,9 +215,7 @@ void close_perf_fd(int fd)
        }
 }
 
-static
-struct perf_event_mmap_page *setup_perf(
-               struct lttng_perf_counter_thread_field *thread_field)
+static void setup_perf(struct lttng_perf_counter_thread_field *thread_field)
 {
        void *perf_addr;
 
@@ -215,13 +223,12 @@ struct perf_event_mmap_page *setup_perf(
                        PROT_READ, MAP_SHARED, thread_field->fd, 0);
        if (perf_addr == MAP_FAILED)
                perf_addr = NULL;
+       thread_field->pc = perf_addr;
 
        if (!arch_perf_keep_fd(thread_field)) {
                close_perf_fd(thread_field->fd);
                thread_field->fd = -1;
        }
-
-       return perf_addr;
 }
 
 static
@@ -296,7 +303,7 @@ struct lttng_perf_counter_thread_field *
        thread_field->field = perf_field;
        thread_field->fd = open_perf_fd(&perf_field->attr);
        if (thread_field->fd >= 0)
-               thread_field->pc = setup_perf(thread_field);
+               setup_perf(thread_field);
        /*
         * Note: thread_field->pc can be NULL if setup_perf() fails.
         * Also, thread_field->fd can be -1 if open_perf_fd() fails.
@@ -360,10 +367,7 @@ static
 void perf_counter_get_value(struct lttng_ctx_field *field,
                struct lttng_ctx_value *value)
 {
-       uint64_t v;
-
-       v = wrapper_perf_counter_read(field);
-       value->u.s64 = v;
+       value->u.s64 = wrapper_perf_counter_read(field);
 }
 
 /* Called with UST lock held */