From 56c23a6713914d9fa898c1a3fe80e21b3e73eef9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 15 Oct 2019 16:56:22 -0400 Subject: [PATCH] Fix: sessiond: application channel creation failure stops start cmd MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The creation of an application's channel can fail when, for instance, a context can't be created. This causes applications that would have been started _after_ it to never be started. This keeps the iteration going on error and starts all applications that could be started. This is more in line with the behaviour of 2.10 (and earlier) since those channel creations would occur as applications registered and not on tracing "start". Signed-off-by: Jérémie Galarneau --- src/bin/lttng-sessiond/ust-app.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/ust-app.c b/src/bin/lttng-sessiond/ust-app.c index a53cf24e2..f4185bc23 100644 --- a/src/bin/lttng-sessiond/ust-app.c +++ b/src/bin/lttng-sessiond/ust-app.c @@ -4212,7 +4212,7 @@ int ust_app_create_channel_glb(struct ltt_ust_session *usess, if (session_was_created) { destroy_app_session(app, ua_sess); } - goto error_rcu_unlock; + /* Continue to the next application. */ } } -- 2.34.1