Fix: build failure with -fno-common
authorMichael Jeanson <mjeanson@efficios.com>
Thu, 16 Jan 2020 19:34:47 +0000 (14:34 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 22 Jan 2020 17:00:39 +0000 (12:00 -0500)
commite1d64b5c248be1da1734357816e029527d6a2cce
treeeb516bccf3cccd7fd2aadf24458ebbb5759b697b
parented523e923bdc1b65d1d3ec5593d0550b29684ab1
Fix: build failure with -fno-common

GCC 10 will default to building with -fno-common, this inhibits the
linker from merging multiple tentative definitions of a symbol in an
archive.

I'm not sure I understand what happen with the symbols in mi-lttng.h
but a similar issue was adressed in:

  commit 4965f956f3ef47388fb4a1b2f8f504abfe31afe7
  Author: Jérémie Galarneau <jeremie.galarneau@efficios.com>
  Date:   Fri May 22 12:53:30 2015 -0400

    Fix: Mark MI and Config string declarations as extern

    This fixes a build issue with GCC 5.1 which would complain about
    these symbols being defined multiple times.

Make sure these symbols are extern and defined only in one compile unit.

For more information, see:
https://gcc.gnu.org/gcc-10/porting_to.html

Change-Id: I139c9695371836cb1011f9ce192080b602ed2fbc
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng-consumerd/lttng-consumerd.h
src/bin/lttng-sessiond/ust-app.c
src/bin/lttng-sessiond/ust-app.h
src/common/mi-lttng.h
tests/regression/tools/live/live_test.c
tests/unit/test_kernel_data.c
tests/unit/test_session.c
tests/unit/test_ust_data.c
This page took 0.027121 seconds and 4 git commands to generate.