Fix: Properly sanitize input parameter
authorYannick Lamarre <ylamarre@efficios.com>
Tue, 26 Mar 2019 19:53:06 +0000 (15:53 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 29 Mar 2019 15:53:40 +0000 (11:53 -0400)
commitcd0a192bca259357d60797584d6ef7978186ac10
treeb6b71e1d629f65dfcbc4e4799402de79edfd5656
parentd7f634f27a26a84e74dcc0db9357fb703fa32f9e
Fix: Properly sanitize input parameter

The lttng client uses the sizeof the containing buffer, defined as
LTTNG_SYMBOL_NAME_LEN, for input string sanitation instead of libc defined
macro NAME_MAX. lttng-enable_channel improperly verified user input
and wrongly discarded valid input in case NAME_MAX was less than the
sizeof the containing buffer for the channel's name.
This patch also fixes potential buffer overflow caused by an improperly
bounded strcpy in the case where NAME_MAX would have been greater than
LTTNG_SYMBOL_NAME_LEN.

Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng/commands/enable_channels.c
This page took 0.025084 seconds and 4 git commands to generate.