Fix: optional.h macro missing parentheses and guards
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 18 Dec 2019 15:50:00 +0000 (10:50 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 20 Dec 2019 00:23:42 +0000 (19:23 -0500)
commit3268167bc3429f7eeab975961f02b7de0ecf22fe
treeed1fa07f548ebe9d08e1f06a38d6f32419dc39a9
parent5ba6017516b4a6d1bc694b2d4ec3569b0348d7c3
Fix: optional.h macro missing parentheses and guards

The are a few coding style issues with optional.h which leads to
unexpected effects when the macros are used in the caller code.

All macro parameters need to be surrounded by () (except when used near
commas, which is the C operator with least precedence).

All macros that emit code need to be surrounded by do { } while (0) so
not to emit extra ; or omit ;, which can cause subtle issues when used
with if/else statements.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Iba6fde7c267f4d8c9ec1a89147045f0bcda3a67a
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/optional.h
This page took 0.024556 seconds and 4 git commands to generate.