Fix: lttng-ctl: erroneous check if user is part of the tracing group
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 3 May 2021 16:50:25 +0000 (12:50 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 11 May 2021 17:30:14 +0000 (13:30 -0400)
commit1a10a4c15204f8aa2e955021100da443414dc6fb
tree2ccb4e5764bd64aa8b0e47d4c63fceb5f132d7ce
parent24cb9f69c5b6247c8c955252f7e468d4c473d4f1
Fix: lttng-ctl: erroneous check if user is part of the tracing group

in_tgroup is set to `-1` whenever the current user is not part of the
tracing group _or_ if an error occurred while looking up if the user
is part of the tracing group. In other words, the value '0' is unused.

in_tgroup must be explicitly checked against '1' and can't be assumed
to behave as a boolean value.

This is _not_ a security issue: if the user is not part of the tracing
group, she will fail to open the root session damon's socket because
of the kernel-side permission checking. However, the behaviour of the
lttng client (and error reporting) will be confusing.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I1c12285fd0f42bb73c560a32a56cab03f1a5a6e1
src/lib/lttng-ctl/lttng-ctl.c
This page took 0.024937 seconds and 4 git commands to generate.