Add valgrind support for consumer
[lttng-tools.git] / src / bin / lttng-sessiond / main.c
index 746f21e456f663b02cd7b8f5a00d913788d3cbd9..ed78b5622911cfc75517814f32a17de7a1738c4d 100644 (file)
@@ -236,6 +236,9 @@ static int app_socket_timeout;
 /* Set in main() with the current page size. */
 long page_size;
 
+/* If set to nonzero, spawn the consumer with valgrind. */
+static int consumer_debug_valgrind;
+
 static
 void setup_consumerd_path(void)
 {
@@ -646,7 +649,8 @@ static int update_kernel_stream(struct consumer_data *consumer_data, int fd)
 
                                                pthread_mutex_lock(socket->lock);
                                                ret = kernel_consumer_send_channel_stream(socket,
-                                                               channel, ksess);
+                                                               channel, ksess,
+                                                               session->output_traces ? 1 : 0);
                                                pthread_mutex_unlock(socket->lock);
                                                if (ret < 0) {
                                                        rcu_read_unlock();
@@ -2031,11 +2035,21 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
                                break;
                        }
                        DBG("Using kernel consumer at: %s",  consumer_to_use);
-                       execl(consumer_to_use,
-                               "lttng-consumerd", verbosity, "-k",
-                               "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
-                               "--consumerd-err-sock", consumer_data->err_unix_sock_path,
-                               NULL);
+                       if (consumer_debug_valgrind) {
+                               execl("/usr/bin/valgrind",
+                                       "valgrind", "--leak-check=full", "--show-reachable=yes",
+                                       "--tool=memcheck", "--track-fds=yes",
+                                       "--log-file=/tmp/valgrind.kconsumer.log",
+                                       consumer_to_use, verbosity, "-k",
+                                       "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
+                                       "--consumerd-err-sock", consumer_data->err_unix_sock_path,
+                                       NULL);
+                       } else {
+                               execl(consumer_to_use, "lttng-consumerd", verbosity, "-k",
+                                       "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
+                                       "--consumerd-err-sock", consumer_data->err_unix_sock_path,
+                                       NULL);
+                       }
                        break;
                case LTTNG_CONSUMER64_UST:
                {
@@ -2070,10 +2084,21 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
                                }
                        }
                        DBG("Using 64-bit UST consumer at: %s",  consumerd64_bin);
-                       ret = execl(consumerd64_bin, "lttng-consumerd", verbosity, "-u",
-                                       "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
-                                       "--consumerd-err-sock", consumer_data->err_unix_sock_path,
-                                       NULL);
+                       if (consumer_debug_valgrind) {
+                               ret = execl("/usr/bin/valgrind",
+                                               "valgrind", "--leak-check=full", "--show-reachable=yes",
+                                               "--tool=memcheck", "--track-fds=yes",
+                                               "--log-file=/tmp/valgrind.ust64consumer.log",
+                                               consumerd64_bin, verbosity, "-u",
+                                               "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
+                                               "--consumerd-err-sock", consumer_data->err_unix_sock_path,
+                                               NULL);
+                       } else {
+                               ret = execl(consumerd64_bin, "lttng-consumerd", verbosity, "-u",
+                                               "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
+                                               "--consumerd-err-sock", consumer_data->err_unix_sock_path,
+                                               NULL);
+                       }
                        if (consumerd64_libdir[0] != '\0') {
                                free(tmpnew);
                        }
@@ -2115,10 +2140,21 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
                                }
                        }
                        DBG("Using 32-bit UST consumer at: %s",  consumerd32_bin);
-                       ret = execl(consumerd32_bin, "lttng-consumerd", verbosity, "-u",
-                                       "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
-                                       "--consumerd-err-sock", consumer_data->err_unix_sock_path,
-                                       NULL);
+                       if (consumer_debug_valgrind) {
+                               ret = execl("/usr/bin/valgrind",
+                                               "valgrind", "--leak-check=full", "--show-reachable=yes",
+                                               "--tool=memcheck", "--track-fds=yes",
+                                               "--log-file=/tmp/valgrind.ust32consumer.log",
+                                               consumerd32_bin, verbosity, "-u",
+                                               "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
+                                               "--consumerd-err-sock", consumer_data->err_unix_sock_path,
+                                               NULL);
+                       } else {
+                               ret = execl(consumerd32_bin, "lttng-consumerd", verbosity, "-u",
+                                               "--consumerd-cmd-sock", consumer_data->cmd_unix_sock_path,
+                                               "--consumerd-err-sock", consumer_data->err_unix_sock_path,
+                                               NULL);
+                       }
                        if (consumerd32_libdir[0] != '\0') {
                                free(tmpnew);
                        }
@@ -2377,6 +2413,7 @@ static int create_ust_session(struct ltt_session *session,
 
        lus->uid = session->uid;
        lus->gid = session->gid;
+       lus->output_traces = session->output_traces;
        session->ust_session = lus;
 
        /* Copy session output to the newly created UST session */
@@ -2433,6 +2470,7 @@ static int create_kernel_session(struct ltt_session *session)
 
        session->kernel_session->uid = session->uid;
        session->kernel_session->gid = session->gid;
+       session->kernel_session->output_traces = session->output_traces;
 
        return LTTNG_OK;
 
@@ -2494,6 +2532,10 @@ static int process_client_msg(struct command_ctx *cmd_ctx, int sock,
        case LTTNG_START_TRACE:
        case LTTNG_STOP_TRACE:
        case LTTNG_DATA_PENDING:
+       case LTTNG_SNAPSHOT_ADD_OUTPUT:
+       case LTTNG_SNAPSHOT_DEL_OUTPUT:
+       case LTTNG_SNAPSHOT_LIST_OUTPUT:
+       case LTTNG_SNAPSHOT_RECORD:
                need_domain = 0;
                break;
        default:
@@ -2562,12 +2604,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx, int sock,
                session_lock_list();
                cmd_ctx->session = session_find_by_name(cmd_ctx->lsm->session.name);
                if (cmd_ctx->session == NULL) {
-                       if (cmd_ctx->lsm->session.name != NULL) {
-                               ret = LTTNG_ERR_SESS_NOT_FOUND;
-                       } else {
-                               /* If no session name specified */
-                               ret = LTTNG_ERR_SELECT_SESS;
-                       }
+                       ret = LTTNG_ERR_SESS_NOT_FOUND;
                        goto error;
                } else {
                        /* Acquire lock for the session */
@@ -3181,6 +3218,67 @@ skip_domain:
                ret = cmd_data_pending(cmd_ctx->session);
                break;
        }
+       case LTTNG_SNAPSHOT_ADD_OUTPUT:
+       {
+               struct lttcomm_lttng_output_id reply;
+
+               ret = cmd_snapshot_add_output(cmd_ctx->session,
+                               &cmd_ctx->lsm->u.snapshot_output.output, &reply.id);
+               if (ret != LTTNG_OK) {
+                       goto error;
+               }
+
+               ret = setup_lttng_msg(cmd_ctx, sizeof(reply));
+               if (ret < 0) {
+                       goto setup_error;
+               }
+
+               /* Copy output list into message payload */
+               memcpy(cmd_ctx->llm->payload, &reply, sizeof(reply));
+               ret = LTTNG_OK;
+               break;
+       }
+       case LTTNG_SNAPSHOT_DEL_OUTPUT:
+       {
+               ret = cmd_snapshot_del_output(cmd_ctx->session,
+                               &cmd_ctx->lsm->u.snapshot_output.output);
+               break;
+       }
+       case LTTNG_SNAPSHOT_LIST_OUTPUT:
+       {
+               ssize_t nb_output;
+               struct lttng_snapshot_output *outputs = NULL;
+
+               nb_output = cmd_snapshot_list_outputs(cmd_ctx->session, &outputs);
+               if (nb_output < 0) {
+                       ret = -nb_output;
+                       goto error;
+               }
+
+               ret = setup_lttng_msg(cmd_ctx,
+                               nb_output * sizeof(struct lttng_snapshot_output));
+               if (ret < 0) {
+                       free(outputs);
+                       goto setup_error;
+               }
+
+               if (outputs) {
+                       /* Copy output list into message payload */
+                       memcpy(cmd_ctx->llm->payload, outputs,
+                                       nb_output * sizeof(struct lttng_snapshot_output));
+                       free(outputs);
+               }
+
+               ret = LTTNG_OK;
+               break;
+       }
+       case LTTNG_SNAPSHOT_RECORD:
+       {
+               ret = cmd_snapshot_record(cmd_ctx->session,
+                               &cmd_ctx->lsm->u.snapshot_record.output,
+                               cmd_ctx->lsm->u.snapshot_record.wait);
+               break;
+       }
        default:
                ret = LTTNG_ERR_UND;
                break;
@@ -4212,6 +4310,13 @@ int main(int argc, char **argv)
                }
        }
 
+       /* Valgrind env. variable setup. */
+       if (getenv(DEFAULT_CONSUMER_DEBUG_VALGRIND_ENV)) {
+               consumer_debug_valgrind = 1;
+               /* Valgrind does not support clone(). */
+               setenv("LTTNG_DEBUG_NOCLONE", "1", 1);
+       }
+
        /* Create thread quit pipe */
        if ((ret = init_thread_quit_pipe()) < 0) {
                goto error;
@@ -4261,7 +4366,7 @@ int main(int argc, char **argv)
                DBG2("Kernel consumer cmd path: %s",
                                kconsumer_data.cmd_unix_sock_path);
        } else {
-               home_path = get_home_dir();
+               home_path = utils_get_home_dir();
                if (home_path == NULL) {
                        /* TODO: Add --socket PATH option */
                        ERR("Can't get HOME directory for sockets creation.");
This page took 0.02654 seconds and 4 git commands to generate.