Fix: atomic_add_unless() returns true/false rather than prior value
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Wed, 8 Mar 2017 16:50:38 +0000 (11:50 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 8 Mar 2017 16:55:48 +0000 (11:55 -0500)
commited62cbfdea7889dba8b3f34550255160616da3a8
treefd2b3e84cd8ac3312398d559448bd137ceb03540
parent95323106a0d5358fa13633d1ceffec44f1a241c2
Fix: atomic_add_unless() returns true/false rather than prior value

The previous implementation assumed that `atomic_add_unless` returned
the prior value of the atomic counter when in fact it returned if the
addition was performed (true) or not performed (false).
Since `atomic_add_unless` can not return INT_MAX, the `lttng_kref_get`
always returned that the call was successful.

This issue had a low likelihood of being triggered since the two refcounts
of the counters used with this call are both bounded by the maximum
number of file descriptors on the system.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
wrapper/kref.h
This page took 0.026894 seconds and 4 git commands to generate.