From 195bef759a5dcdea7ac2a77517d2e1fdd62db52f Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Fri, 16 Nov 2018 13:25:00 -0500 Subject: [PATCH] Fix: tests: test_crash should start sessions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit test_crash expects side-effects of directory creation to happen while tracing is still stopped. In preparation for changing that behavior, ensure that tracing is started when those side-effects are expected. Signed-off-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- tests/regression/tools/crash/test_crash | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/regression/tools/crash/test_crash b/tests/regression/tools/crash/test_crash index 3bf459dc2..13909c1bf 100755 --- a/tests/regression/tools/crash/test_crash +++ b/tests/regression/tools/crash/test_crash @@ -31,7 +31,7 @@ NR_ITER=-1 # Temp file output OUTPUT_DIR=$(mktemp -d) -NUM_TESTS=73 +NUM_TESTS=77 source $TESTDIR/utils/utils.sh @@ -106,6 +106,8 @@ function test_shm_path_per_pid() create_lttng_session_ok $session_name $OUTPUT_DIR "--shm-path $shm_path" enable_ust_lttng_channel_ok $session_name $channel_name "--buffers-pid" + start_lttng_tracing_ok $session_name + diag "Shm: clean state" file_count=$(find $shm_path -mindepth 1 -maxdepth 1 | wc -l) test $file_count -eq "0" @@ -174,6 +176,8 @@ function test_shm_path_per_uid() create_lttng_session_ok $session_name $OUTPUT_DIR "--shm-path $shm_path" enable_ust_lttng_channel_ok $session_name $channel_name "--buffers-uid" + start_lttng_tracing_ok $session_name + diag "Shm: test clean state" file_count=$(find $shm_path -mindepth 1 -maxdepth 1 | wc -l) test $file_count -eq "0" @@ -295,6 +299,8 @@ function test_shm_path_per_pid_sigint() create_lttng_session_ok $session_name $OUTPUT_DIR "--shm-path $shm_path" enable_ust_lttng_channel_ok $session_name $channel_name "--buffers-pid" + start_lttng_tracing_ok $session_name + start_test_app start_test_app shm_session_path=$(find $shm_path -mindepth 1 -maxdepth 1) @@ -324,6 +330,8 @@ function test_shm_path_per_uid_sigint() create_lttng_session_ok $session_name $OUTPUT_DIR "--shm-path $shm_path" enable_ust_lttng_channel_ok $session_name $channel_name "--buffers-uid" + start_lttng_tracing_ok $session_name + start_test_app start_test_app shm_session_path=$(find $shm_path -mindepth 1 -maxdepth 1) -- 2.34.1