lttng-modules.git
4 years agoinstrumentation: power: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:21:59 +0000 (16:21 -0400)] 
instrumentation: power: remove compatibility code

4 years agoinstrumentation: net: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:18:35 +0000 (16:18 -0400)] 
instrumentation: net: remove compatibility code

4 years agoinstrumentation: napi: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:17:44 +0000 (16:17 -0400)] 
instrumentation: napi: remove compatibility code

4 years agoinstrumentation: module: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:17:12 +0000 (16:17 -0400)] 
instrumentation: module: remove compatibility code

4 years agoinstrumentation: mm_vmscan: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:16:45 +0000 (16:16 -0400)] 
instrumentation: mm_vmscan: remove compatibility code

4 years agoinstrumentation: lttng-test.h: remove unused include version.h
Mathieu Desnoyers [Mon, 13 Apr 2020 20:14:34 +0000 (16:14 -0400)] 
instrumentation: lttng-test.h: remove unused include version.h

4 years agoinstrumentation: lttng-statedump: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:14:15 +0000 (16:14 -0400)] 
instrumentation: lttng-statedump: remove compatibility code

4 years agoinstrumentation: kvm: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:13:10 +0000 (16:13 -0400)] 
instrumentation: kvm: remove compatibility code

4 years agoinstrumentation: kmem: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:11:45 +0000 (16:11 -0400)] 
instrumentation: kmem: remove compatibility code

4 years agoinstrumentation: jbd: remove deprecated probe
Mathieu Desnoyers [Mon, 13 Apr 2020 20:07:41 +0000 (16:07 -0400)] 
instrumentation: jbd: remove deprecated probe

4 years agoinstrumentation: jbd2: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:06:58 +0000 (16:06 -0400)] 
instrumentation: jbd2: remove compatibility code

4 years agoinstrumentation: ext3: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 20:05:45 +0000 (16:05 -0400)] 
instrumentation: ext3: remove compatibility code

4 years agoinstrumentation: remove deprecated ext3 probe
Mathieu Desnoyers [Mon, 13 Apr 2020 20:00:50 +0000 (16:00 -0400)] 
instrumentation: remove deprecated ext3 probe

4 years agoinstrumentation: compaction: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 19:58:51 +0000 (15:58 -0400)] 
instrumentation: compaction: remove compatibility code

4 years agoinstrumentation: btrfs: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 19:57:54 +0000 (15:57 -0400)] 
instrumentation: btrfs: remove compatibility code

4 years agoinstrumentation: block: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 19:51:53 +0000 (15:51 -0400)] 
instrumentation: block: remove compatibility code

4 years agoinstrumentation: remove asoc probe
Mathieu Desnoyers [Mon, 13 Apr 2020 19:48:23 +0000 (15:48 -0400)] 
instrumentation: remove asoc probe

4 years agoinstrumentation: 9p: remove compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 19:47:26 +0000 (15:47 -0400)] 
instrumentation: 9p: remove compatibility code

4 years agoinstrumentation: syscalls: remove backward compatibility for older kernels
Mathieu Desnoyers [Mon, 13 Apr 2020 19:43:49 +0000 (15:43 -0400)] 
instrumentation: syscalls: remove backward compatibility for older kernels

4 years agowrapper: user_namespace.h: remove backward compatibility code
Mathieu Desnoyers [Mon, 13 Apr 2020 19:41:00 +0000 (15:41 -0400)] 
wrapper: user_namespace.h: remove backward compatibility code

4 years agowrapper: remove list wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 19:37:48 +0000 (15:37 -0400)] 
wrapper: remove list wrapper

4 years agowrapper: remove kallsyms wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 19:26:36 +0000 (15:26 -0400)] 
wrapper: remove kallsyms wrapper

4 years agowrapper: remove inline_memcpy.h
Mathieu Desnoyers [Mon, 13 Apr 2020 19:25:58 +0000 (15:25 -0400)] 
wrapper: remove inline_memcpy.h

4 years agowrapper: compiler.h: remove READ_ONCE/WRITE_ONCE wrappers
Mathieu Desnoyers [Mon, 13 Apr 2020 19:20:57 +0000 (15:20 -0400)] 
wrapper: compiler.h: remove READ_ONCE/WRITE_ONCE wrappers

4 years agowrapper: remove atomic.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 19:19:25 +0000 (15:19 -0400)] 
wrapper: remove atomic.h wrapper

4 years agocallstack context: use GPL-exported symbols
Mathieu Desnoyers [Mon, 13 Apr 2020 19:13:06 +0000 (15:13 -0400)] 
callstack context: use GPL-exported symbols

4 years agowrapper: remove genhd wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:51:23 +0000 (14:51 -0400)] 
wrapper: remove genhd wrapper

4 years agowrapper: remove task prio wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:48:32 +0000 (14:48 -0400)] 
wrapper: remove task prio wrapper

4 years agowrapper: remove namespace.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:46:22 +0000 (14:46 -0400)] 
wrapper: remove namespace.h wrapper

4 years agowrapper: remove page_alloc wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:42:50 +0000 (14:42 -0400)] 
wrapper: remove page_alloc wrapper

4 years agowrapper: remove perf wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:40:18 +0000 (14:40 -0400)] 
wrapper: remove perf wrapper

4 years agoFix: wrapper random documentation
Mathieu Desnoyers [Mon, 13 Apr 2020 18:38:51 +0000 (14:38 -0400)] 
Fix: wrapper random documentation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agowrapper: remove syscall wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:35:58 +0000 (14:35 -0400)] 
wrapper: remove syscall wrapper

4 years agowrapper: remove timer wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:31:50 +0000 (14:31 -0400)] 
wrapper: remove timer wrapper

4 years agowrapper: remove uprobes wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:27:55 +0000 (14:27 -0400)] 
wrapper: remove uprobes wrapper

4 years agowrapper: remove types.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:26:24 +0000 (14:26 -0400)] 
wrapper: remove types.h wrapper

4 years agowrapper: remove percpu-defs.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:24:16 +0000 (14:24 -0400)] 
wrapper: remove percpu-defs.h wrapper

4 years agowrapper: remove mm.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:22:27 +0000 (14:22 -0400)] 
wrapper: remove mm.h wrapper

4 years agowrapper: remove frame.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:18:51 +0000 (14:18 -0400)] 
wrapper: remove frame.h wrapper

4 years agowrapper: remove file.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:14:41 +0000 (14:14 -0400)] 
wrapper: remove file.h wrapper

4 years agowrapper: remove irq wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:10:19 +0000 (14:10 -0400)] 
wrapper: remove irq wrapper

4 years agowrapper: remove poll wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 18:08:04 +0000 (14:08 -0400)] 
wrapper: remove poll wrapper

4 years agowrapper: remove kref_get wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:49:11 +0000 (12:49 -0400)] 
wrapper: remove kref_get wrapper

4 years agowrapper: remove tracepoint wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:39:24 +0000 (12:39 -0400)] 
wrapper: remove tracepoint wrapper

4 years agowrapper: remove lttng_access_ok() wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:34:46 +0000 (12:34 -0400)] 
wrapper: remove lttng_access_ok() wrapper

4 years agowrapper: remove time.h wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:32:17 +0000 (12:32 -0400)] 
wrapper: remove time.h wrapper

4 years agowrapper: remove writeback wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:31:00 +0000 (12:31 -0400)] 
wrapper: remove writeback wrapper

4 years agowrapper: remove fdtable wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:26:59 +0000 (12:26 -0400)] 
wrapper: remove fdtable wrapper

4 years agowrapper: remove splice_to_pipe wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:23:25 +0000 (12:23 -0400)] 
wrapper: remove splice_to_pipe wrapper

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agowrapper: Remove irqdesc wrapper
Mathieu Desnoyers [Mon, 13 Apr 2020 16:20:27 +0000 (12:20 -0400)] 
wrapper: Remove irqdesc wrapper

4 years agoFix: add missing wrapper include to lttng-context-callstack.c
Mathieu Desnoyers [Mon, 13 Apr 2020 16:18:36 +0000 (12:18 -0400)] 
Fix: add missing wrapper include to lttng-context-callstack.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agowrapper: remove vmalloc_sync_all
Mathieu Desnoyers [Mon, 13 Apr 2020 15:09:13 +0000 (11:09 -0400)] 
wrapper: remove vmalloc_sync_all

4 years agoUse guid_gen for kernels >= 5.7.0
Mathieu Desnoyers [Mon, 13 Apr 2020 16:16:43 +0000 (12:16 -0400)] 
Use guid_gen for kernels >= 5.7.0

** note: removes backward compatibility. **

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoUpdate writeback instrumentation for kernel >= 5.7.0
Mathieu Desnoyers [Mon, 13 Apr 2020 16:13:39 +0000 (12:13 -0400)] 
Update writeback instrumentation for kernel >= 5.7.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoUpdate x86 kvm instrumentation for kernel >= 5.7.0
Mathieu Desnoyers [Mon, 13 Apr 2020 16:06:05 +0000 (12:06 -0400)] 
Update x86 kvm instrumentation for kernel >= 5.7.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoinstrumentation: update x86 kvm instrumentation for kernel >= 5.7.0
Mathieu Desnoyers [Mon, 13 Apr 2020 15:44:23 +0000 (11:44 -0400)] 
instrumentation: update x86 kvm instrumentation for kernel >= 5.7.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoinstrumentation: update mm_vmscan for kernel >= 5.7.0
Mathieu Desnoyers [Mon, 13 Apr 2020 15:38:48 +0000 (11:38 -0400)] 
instrumentation: update mm_vmscan for kernel >= 5.7.0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agotracepoint: Refactor representation of nested types before-upstreaming
Mathieu Desnoyers [Tue, 7 Apr 2020 17:07:54 +0000 (13:07 -0400)] 
tracepoint: Refactor representation of nested types

Refactor enumeration, sequence, array, structure, and variant types.

Implement internal data structures to support nested types.

All probe providers using ctf_enum(), ctf_array*() and ctf_sequence*()
are switched to this new internal type representation.

Each of sequence, array, struct and variant gain a "alignment" property,
which is a feature which was needed in lttng-modules to express
alignment for an array or sequence of bits.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agowrapper/compiler.h: Implement __LTTNG_COMPOUND_LITERAL
Mathieu Desnoyers [Mon, 6 Apr 2020 16:00:47 +0000 (12:00 -0400)] 
wrapper/compiler.h: Implement __LTTNG_COMPOUND_LITERAL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoUpdate to SPDX v3.0 identifiers
Michael Jeanson [Tue, 31 Mar 2020 18:29:29 +0000 (14:29 -0400)] 
Update to SPDX v3.0 identifiers

The short form of GPL-2.0 and LGPL-2.1 were deprecated in favour of the
clearer GPL-2.0-only and GPL-2.0-or-later in the SPDX license list v3.0.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: If2337f5c67a2548d7f25043e67006211213cbe3e

4 years agofix: uaccess wrapper for CentOS >= 4.18.0-147
Michael Jeanson [Thu, 2 Apr 2020 18:08:36 +0000 (14:08 -0400)] 
fix: uaccess wrapper for CentOS >= 4.18.0-147

Fixes: #1253
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I2a79c1c0e897a6148e60e5599949cd2778d09d50

4 years agofix: ext4 instrumentation for CentOS >= 4.18.0-147
Michael Jeanson [Thu, 2 Apr 2020 18:08:09 +0000 (14:08 -0400)] 
fix: ext4 instrumentation for CentOS >= 4.18.0-147

Fixes: #1253
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I1fd54af16fbb02cd4b3ab7fc7d9232708088f1fd

4 years agofix: signal instrumentation for CentOS >= 4.18.0-147
Michael Jeanson [Thu, 2 Apr 2020 18:07:47 +0000 (14:07 -0400)] 
fix: signal instrumentation for CentOS >= 4.18.0-147

Fixes: #1253
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I280013402df6f14222fbb912cdf64d80af3ab265

4 years agofix: kvm instrumentation for CentOS >= 4.18.0-147
Michael Jeanson [Thu, 2 Apr 2020 18:07:21 +0000 (14:07 -0400)] 
fix: kvm instrumentation for CentOS >= 4.18.0-147

Fixes: #1253
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Ide20ebf51bec503866ffc96dda3e0b09ebeb14d6

4 years agofix: rcu instrumentation for CentOS >= 4.18.0-80
Michael Jeanson [Thu, 2 Apr 2020 18:06:17 +0000 (14:06 -0400)] 
fix: rcu instrumentation for CentOS >= 4.18.0-80

Fixes: #1253
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I1735d2caa7215ce94272aaaa98cbbc8f3a10743d

4 years agoFix: update kvm instrumentation for Ubuntu 5.3.0-45
Michael Jeanson [Mon, 30 Mar 2020 21:43:16 +0000 (17:43 -0400)] 
Fix: update kvm instrumentation for Ubuntu 5.3.0-45

This commit introduced in 5.3.0-43 was dropped in 5.3.0-45 and reintroduced
in 5.3.0-46:

  commit 795f8a34f279e17c279bba46da10f15c5dd00264
  Author: Sean Christopherson <sean.j.christopherson@intel.com>
  Date:   Fri Dec 6 15:57:14 2019 -0800

    KVM: x86: Use gpa_t for cr2/gpa to fix TDP support on 32-bit KVM

BugLink: https://bugs.launchpad.net/bugs/1867051
    [ Upstream commit 736c291c9f36b07f8889c61764c28edce20e715d ]

Fun times!

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Ia5f1a4ba355f592f09e964038b6334ddb3ad5153

4 years agoFix: update kvm instrumentation for Ubuntu 5.3.0-43
Michael Jeanson [Tue, 24 Mar 2020 18:20:48 +0000 (14:20 -0400)] 
Fix: update kvm instrumentation for Ubuntu 5.3.0-43

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I1ce5f9ebba997fcc4cfbae6901eed479e2e1a79e

4 years agoFix: fcntl enum: only emit F_GETOWNER_UIDS for kernels >= 3.6
Mathieu Desnoyers [Tue, 24 Mar 2020 13:42:23 +0000 (09:42 -0400)] 
Fix: fcntl enum: only emit F_GETOWNER_UIDS for kernels >= 3.6

It appears in upstream Linux kernel
commit 1d151c337d79 "c/r: fcntl: add F_GETOWNER_UIDS option"
which was first released in v3.6.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agosyscalls: Make the cmd field of fcntl an enum
Geneviève Bastien [Wed, 11 Mar 2020 16:38:51 +0000 (12:38 -0400)] 
syscalls: Make the cmd field of fcntl an enum

The fcntl system call has a cmd parameter which is one of multiple
values defined in the linux/fcntl.h file. This field is now an
enumeration of the various possible values.

Here's an example babeltrace output of the fcntl system call:

[...] syscall_entry_fcntl: { cpu_id = 3 }, { fd = 35,
cmd = ( "F_GETFL" : container = 3 ), arg = 140388746332169 }

Change-Id: I06f511d5dba986aaf01b50057cbe6eac789bbea7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agosyscalls: Make the flags and mode fields of open[at] enumerations
Geneviève Bastien [Wed, 11 Mar 2020 16:33:04 +0000 (12:33 -0400)] 
syscalls: Make the flags and mode fields of open[at] enumerations

The open and openat system call have a flags and mode fields, whose values
are defined in the linux/fcntl.h file. These fields are now
enumerations that can be read as a bit field enum, to make the values more
readable / meaningful.

Here's an example babeltrace output of the open system call:

[...] syscall_entry_openat: { cpu_id = 0 }, { dfd = -100,
filename = "/tmp/edg0_383407",
flags = ( "O_RDWR" | "O_CREAT" | "O_TRUNC" : container = 578 ),
mode = ( "S_IWOTH" | "S_IROTH" | "S_IWGRP" | "S_IRGRP" |
   "S_IWUSR" | "S_IRUSR" : container = 438 ) }

Change-Id: Id7a516670b03e52fc75f9ff3c6ba8114c61a3865
Signed-off-by: Geneviève Bastien <gbastien@versatic.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoFix: update kvm instrumentation for Ubuntu 4.15.0-92
Michael Jeanson [Mon, 23 Mar 2020 18:48:24 +0000 (14:48 -0400)] 
Fix: update kvm instrumentation for Ubuntu 4.15.0-92

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Ib367b9a0ce3846f45313906e710a9a6d644e3955

4 years agoRecord event as soon as one filter evaluates to TRUE
Francis Deslauriers [Fri, 20 Mar 2020 20:23:17 +0000 (16:23 -0400)] 
Record event as soon as one filter evaluates to TRUE

This is a tiny optimization but it can reduce tracing cost in cases
where multiple filters are attached to a probe.

Since we want to trace an event if any of its filter expressions
evaluates to TRUE, there is no need to keep on evaluating expressions
once one is found to be TRUE.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I6b5b7697869d3e25dc24d38dc39c34ae1d49dcc9

4 years agoAdd UDP and ICMP packet header information to the tracepoint
Florian Walbroel via lttng-dev [Tue, 17 Mar 2020 09:03:19 +0000 (10:03 +0100)] 
Add UDP and ICMP packet header information to the tracepoint

* UDP transport header
* ICMP transport header

Signed-off-by: Florian Walbroel <walbroel@silexica.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agostatedump: introduce file_table_address
Mathieu Desnoyers [Tue, 10 Mar 2020 19:00:29 +0000 (15:00 -0400)] 
statedump: introduce file_table_address

Currently the LTTng-modules statedump simply iterates over all processes
in the system and assumes all threads share the same file descriptor
table, which is only true if threads were created with clone
CLONE_FILES.

Directly invoking clone without the CLONE_FILES creates threads which
belong to the same process, but have their own file descriptor table.

Therefore, model-wise, we cannot assume that all threads in a process
have the same fd table content.

Add a new "file_table_address" field to the lttng_statedump_process_state
event, which dumps the address of the thread's struct files_struct
pointer. This pointer is guaranteed to never be re-used while we hold
the RCU read-side lock (so for the entire iteration over
processes/threads).

For the lttng_statedump_file_descriptor event, remove the "pid" field
(which is semantically inaccurate) and add a "file_table_address" field,
which contains the struct files_struct address of the file table
containing the file descriptor.

An optimization is performed to eliminate most duplcated file table
content by skipping file table dump if the same file table address is
encountered consecutively while iterating over a process' threads.

This introduces a semantic change to the statedump fields, and will
therefore be introduced in lttng-modules 2.12 onwards, not backported as
a fix.

Fixes: #1245
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoRemove kernel version from syscall headers name
Michael Jeanson [Wed, 4 Mar 2020 20:45:18 +0000 (15:45 -0500)] 
Remove kernel version from syscall headers name

This will reduce the delta when updating the syscall headers and make it
easier to track the changes.

Add a comment in the headers to track the version they were generated
from.

Change-Id: I939e1ebd8ab18d880ff1394e771982b5491d3b19
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoAdd script to automate the syscall extraction process
Michael Jeanson [Wed, 4 Mar 2020 20:37:11 +0000 (15:37 -0500)] 
Add script to automate the syscall extraction process

Change-Id: Ic8e1e62058616f221569e1f5ed2ffb9d54275af5
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoUpdate lttng-syscalls-extractor for v5.6.0
Michael Jeanson [Wed, 4 Mar 2020 20:21:03 +0000 (15:21 -0500)] 
Update lttng-syscalls-extractor for v5.6.0

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I48e4d82484d6edcc7601a40d2f94e5c46ad5184b

4 years agoAdd a Makefile for the lttng-syscalls-extractor module
Michael Jeanson [Wed, 4 Mar 2020 20:06:41 +0000 (15:06 -0500)] 
Add a Makefile for the lttng-syscalls-extractor module

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I0c1cc650d8594ef01b4039bb3d2af94bfddea54d

4 years agoCleanup: Syscall headers scripts shellcheck warnings
Michael Jeanson [Fri, 14 Feb 2020 21:38:27 +0000 (16:38 -0500)] 
Cleanup: Syscall headers scripts shellcheck warnings

Change-Id: Ia616724d942f43f5fde2186bff28446120b17c43
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoRemove lttng-ftrace integration
Mathieu Desnoyers [Mon, 2 Mar 2020 16:26:39 +0000 (11:26 -0500)] 
Remove lttng-ftrace integration

The lttng-ftrace integration (LTTNG_KERNEL_FUNCTION instrumentation
type) was unused for a while now. The "function" probing is actually
done with kprobes and kretprobes (LTTNG_KERNEL_KPROBE and
LTTNG_KERNEL_KRETPROBE).

Remove it so a use of kallsyms_lookup_name() can be removed as well.
Note that in the future we could add back this support by using
register_ftrace_function() which is exported to kernel modules, but
considering that we have not been using this code for a while,
just remove the implementation for now.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoRemove dependency on kallsyms for splice_to_pipe (kernel 4.2+)
Mathieu Desnoyers [Mon, 2 Mar 2020 16:03:19 +0000 (11:03 -0500)] 
Remove dependency on kallsyms for splice_to_pipe (kernel 4.2+)

Upstream commit 2b514574f7e88 "net: af_unix: implement splice for stream
af_unix sockets" exported the "splice_to_pipe" symbol, so use it to
remove a dependency on kallsyms_lookup_name().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoRemove dependency on kallsyms for irq_to_desc (kernel 3.4+)
Mathieu Desnoyers [Mon, 2 Mar 2020 15:52:54 +0000 (10:52 -0500)] 
Remove dependency on kallsyms for irq_to_desc (kernel 3.4+)

Upstream commit 3911ff30f5d "genirq: export handle_edge_irq() and
irq_to_desc()" exported the irq_to_desc symbol, so use it to remove a
dependency on kallsyms_lookup_name().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoRemove work-around for signed tracepoint module tainting (kernel 3.15+)
Mathieu Desnoyers [Mon, 2 Mar 2020 15:40:26 +0000 (10:40 -0500)] 
Remove work-around for signed tracepoint module tainting (kernel 3.15+)

Upstream commit 66cc69e34e86a "Fix: module signature vs tracepoints: add
new TAINT_UNSIGNED_MODULE" fixed an issue where the kernel was
considering unsigned modules as tainting the kernel in the same way as a
force-loaded modules, which was causing the tracepoints within those
modules to be hidden.

This fix was merged in kernel 3.15, so there is no use in applying this
work-around starting from that kernel.

This removes a dependency on kallsyms_lookup_name() for the symbol
"tracepoint_module_notify".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoChange integer base to hex for fields representing addresses
Francis Deslauriers [Fri, 21 Feb 2020 21:59:33 +0000 (16:59 -0500)] 
Change integer base to hex for fields representing addresses

It seems more expected to show addresses in hexadecimal.

I applied this to all fields named "ip" or "addr".

I haven't change the `addr` fields in the i2c.h file as I am not aware
of what is the convention when displaying I2C addresses.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I6ed00b31e319e1d966ab138471248dcf3d2c7315

4 years agoFix: rcu: Fix data-race due to atomic_t copy-by-value (5.5.6, 5.4.22)
Mathieu Desnoyers [Tue, 25 Feb 2020 15:18:11 +0000 (10:18 -0500)] 
Fix: rcu: Fix data-race due to atomic_t copy-by-value (5.5.6, 5.4.22)

The following upstream commit has been backported to stable kernels
5.5.6 and 5.4.22:

  commit 6cf539a87a61a4fbc43f625267dbcbcf283872ed
  Author: Marco Elver <elver@google.com>
  Date:   Wed Oct 9 17:57:43 2019 +0200

    rcu: Fix data-race due to atomic_t copy-by-value

    This fixes a data-race where `atomic_t dynticks` is copied by value. The
    copy is performed non-atomically, resulting in a data-race if `dynticks`
    is updated concurrently.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agofix: y2038: hide timeval/timespec/itimerval/itimerspec types (v5.6)
Michael Jeanson [Mon, 24 Feb 2020 20:11:03 +0000 (15:11 -0500)] 
fix: y2038: hide timeval/timespec/itimerval/itimerspec types (v5.6)

See upstream commit:

  commit c766d1472c70d25ad475cf56042af1652e792b23
  Author: Arnd Bergmann <arnd@arndb.de>
  Date:   Thu Feb 20 20:03:57 2020 -0800

    y2038: hide timeval/timespec/itimerval/itimerspec types

    There are no in-kernel users remaining, but there may still be users that
    include linux/time.h instead of sys/time.h from user space, so leave the
    types available to user space while hiding them from kernel space.

    Only the __kernel_old_* versions of these types remain now.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I986a813ad8b1c753ab1fa07f726b0cc481f049cb

4 years agofix: use timespec64 on kernels that have it
Michael Jeanson [Mon, 24 Feb 2020 19:50:20 +0000 (14:50 -0500)] 
fix: use timespec64 on kernels that have it

This fixes v5.6 which has hidden 'struct timespec' from kernel code and
makes 32bit archs y2038 compliant on v3.17 and newer.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I1daedc4a93cbbebb8f5a1d99c4619cb27f6a9e07

4 years agofix: move lttng_close_on_exec to proper wrapper
Michael Jeanson [Mon, 24 Feb 2020 20:15:36 +0000 (15:15 -0500)] 
fix: move lttng_close_on_exec to proper wrapper

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I330c6d63fc9c1af00c9a9471563d322d036b9a9c

4 years agofix: 'struct timex' removed upstream (v5.6)
Michael Jeanson [Mon, 24 Feb 2020 16:30:22 +0000 (11:30 -0500)] 
fix: 'struct timex' removed upstream (v5.6)

The 'timex' struct was remove in v5.6 and replaced by 2 variants, one
that is y2038 compliant and a compat version for 32bit archs.

Add this temporary fix while we update our syscalls tracepoint headers,
the type of this struct has limited importance since it's only used to
record the adress in the trace.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Change-Id: I085b22f282db57985f1c3d341e7c0866cb20e3c9

4 years agoFix: statedump: consistently check task_cred_xxx() return value for NULL
Mathieu Desnoyers [Thu, 20 Feb 2020 15:46:25 +0000 (10:46 -0500)] 
Fix: statedump: consistently check task_cred_xxx() return value for NULL

trace_lttng_statedump_process_user_ns() internally checks whether
user_ns is NULL. While this does not appear to be a possible return
value for task_cred_xxx(), err on the safe side and check for NULL here
as well to be consistent with the paranoid behavior of
trace_lttng_statedump_process_user_ns().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoFix: statedump: check task_active_pid_ns return value for NULL
Mathieu Desnoyers [Thu, 20 Feb 2020 14:58:42 +0000 (09:58 -0500)] 
Fix: statedump: check task_active_pid_ns return value for NULL

The lttng-statedump checks the return value of task_active_pid_ns()
before each use within lttng_statedump_process_pid_ns(), but misses
the NULL check before dereferencing pid_ns->parent.

This race happens if a task exists in "dead" state while the statedump
iterates on that task.

Reported-by: Li Zhou <li.zhou@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoFix: lttng-events.c: variable may be used uninitialized
Francis Deslauriers [Tue, 4 Feb 2020 21:05:30 +0000 (16:05 -0500)] 
Fix: lttng-events.c: variable may be used uninitialized

Fixes the following warning:
/home/frdeso/projets/lttng/modules/lttng-events.c: In function ‘print_metadata_escaped_field’:
/home/frdeso/projets/lttng/modules/lttng-events.c:2563:5: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (ret)
           ^

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: If2db5e1ad9782fb49d6d07026976d3d22f89f2ab

4 years agoCleanup: remove trailing white spaces across project
Francis Deslauriers [Mon, 17 Feb 2020 23:13:56 +0000 (18:13 -0500)] 
Cleanup: remove trailing white spaces across project

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I2de34e4913f9cefbd72a138f2d3dfb9d67ece311

4 years agosched: Make the sched_switch task state an enum
Geneviève Bastien [Wed, 12 Feb 2020 21:58:25 +0000 (16:58 -0500)] 
sched: Make the sched_switch task state an enum

This gives meaning to the task state value. Only the bit masks are
enumerated, as defined compositions are not exhaustive listing of all
possible values and there would be a lot of unknown. Interpretation of
combination of bit flags is left to the consumer of the event.

Change-Id: I83c5fbee9cba2701c7238c0ac6abd4c8a351b193
Signed-off-by: Geneviève Bastien <gbastien@versatic.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agoblock: Make the rwbs field as a bit field enum
Geneviève Bastien [Tue, 11 Feb 2020 16:20:27 +0000 (11:20 -0500)] 
block: Make the rwbs field as a bit field enum

The rwbs value of block request events is in fact a series of bit fields
set to 0 or 1. The enumeration values are all powers of 2, trace readers
could interpret this as a bit field enum and show the result as a
concatenation of the corresponding flags. For example, with a matching
patch for babeltrace2's pretty sink, the output for a rwbs value of 12
would be:

[13:15:49.024354958] (+0.000003868) wilbrod block_rq_complete: { cpu_id = 4 },
    { dev = 8388624, sector = 375490176, nr_sector = 360, error = 0,
      rwbs = ( "RWBS_FLAG_READ" | "RWBS_FLAG_RAHEAD" : container = 12 ) }

Consumers who have no notion of the bit field enum can still use the
integer value of the field as before.

Change-Id: I2e873f16e5a0507e52cfc85c70b471a9f4d5d5d1
Signed-off-by: Geneviève Bastien <gbastien@versatic.net>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agofix: workqueue: add worker function to workqueue_execute_end tracepoint (v5.6)
Michael Jeanson [Tue, 11 Feb 2020 20:35:11 +0000 (15:35 -0500)] 
fix: workqueue: add worker function to workqueue_execute_end tracepoint (v5.6)

See upstream commit :

  commit 1c5da0ec7f20dfb56030fb93f7f52f48e12deb52
  Author: Daniel Jordan <daniel.m.jordan@oracle.com>
  Date:   Mon Jan 13 17:52:39 2020 -0500

    workqueue: add worker function to workqueue_execute_end tracepoint

    It's surprising that workqueue_execute_end includes only the work when
    its counterpart workqueue_execute_start has both the work and the worker
    function.

    You can't set a tracing filter or trigger based on the function, and
    postprocessing scripts interested in specific functions are harder to
    write since they have to remember the work from _start and match it up
    with the same field in _end.

    Add the function name, taking care to use the copy stashed in the
    worker since the work is no longer safe to touch.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agofix: media: v4l2: abstract timeval handling in v4l2_buffer (v5.6)
Michael Jeanson [Tue, 11 Feb 2020 20:13:53 +0000 (15:13 -0500)] 
fix: media: v4l2: abstract timeval handling in v4l2_buffer (v5.6)

See upstream commit :

  commit 77cdffcb0bfb87fe3645894335cb8cb94917e6ac
  Author: Arnd Bergmann <arnd@arndb.de>
  Date:   Mon Dec 16 15:15:00 2019 +0100

    media: v4l2: abstract timeval handling in v4l2_buffer

    As a preparation for adding 64-bit time_t support in the uapi,
    change the drivers to no longer care about the format of the
    timestamp field in struct v4l2_buffer.

    The v4l2_timeval_to_ns() function is no longer needed in the
    kernel after this, but there is userspace code relying on
    it to be part of the uapi header.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agofix: rcu: Remove kfree_rcu() special casing and lazy-callback (v5.6)
Michael Jeanson [Tue, 11 Feb 2020 20:08:04 +0000 (15:08 -0500)] 
fix: rcu: Remove kfree_rcu() special casing and lazy-callback (v5.6)

See upstream commit :

  commit 77a40f97030b27b3fc1640a3ed203870f0817f57
  Author: Joel Fernandes (Google) <joel@joelfernandes.org>
  Date:   Fri Aug 30 12:36:32 2019 -0400

    rcu: Remove kfree_rcu() special casing and lazy-callback handling

    This commit removes kfree_rcu() special-casing and the lazy-callback
    handling from Tree RCU.  It moves some of this special casing to Tiny RCU,
    the removal of which will be the subject of later commits.

    This results in a nice negative delta.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agofix: rcu: Fix data-race due to atomic_t copy-by-value (v5.6)
Michael Jeanson [Tue, 11 Feb 2020 19:51:01 +0000 (14:51 -0500)] 
fix: rcu: Fix data-race due to atomic_t copy-by-value (v5.6)

See upstream commit :

  commit 6cf539a87a61a4fbc43f625267dbcbcf283872ed
  Author: Marco Elver <elver@google.com>
  Date:   Wed Oct 9 17:57:43 2019 +0200

    rcu: Fix data-race due to atomic_t copy-by-value

    This fixes a data-race where `atomic_t dynticks` is copied by value. The
    copy is performed non-atomically, resulting in a data-race if `dynticks`
    is updated concurrently.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
4 years agofix: btrfs: make btrfs_ordered_extent naming consistent (v5.6)
Michael Jeanson [Tue, 11 Feb 2020 19:47:23 +0000 (14:47 -0500)] 
fix: btrfs: make btrfs_ordered_extent naming consistent (v5.6)

See upstream commit :

  commit bffe633e00fb6b904817137fc17a44b42efcd985
  Author: Omar Sandoval <osandov@fb.com>
  Date:   Mon Dec 2 17:34:19 2019 -0800

    btrfs: make btrfs_ordered_extent naming consistent with btrfs_file_extent_item

    ordered->start, ordered->len, and ordered->disk_len correspond to
    fi->disk_bytenr, fi->num_bytes, and fi->disk_num_bytes, respectively.
    It's confusing to translate between the two naming schemes. Since a
    btrfs_ordered_extent is basically a pending btrfs_file_extent_item,
    let's make the former use the naming from the latter.

    Note that I didn't touch the names in tracepoints just in case there are
    scripts depending on the current naming.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.044898 seconds and 4 git commands to generate.