Fix: Initialize fd field of struct lttng_ust_elf to -1 at allocation
authorJonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Wed, 14 Nov 2018 19:38:37 +0000 (14:38 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tue, 22 Jan 2019 21:52:19 +0000 (16:52 -0500)
In rare cases when the executable cannot be open, using a default value
of zero lead to invalid close call and fd tracker removal.

fixes #1171

Reported-by: Stefan Palade <stefan.palade@windriver.com>
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
liblttng-ust/lttng-ust-elf.c

index c073e7a545b64d349d3d7bb56932a24b9025f657..3d6a9379f7a5e44b6837c01fbb5c72a92bd32162 100644 (file)
@@ -250,6 +250,8 @@ struct lttng_ust_elf *lttng_ust_elf_create(const char *path)
                goto error;
        }
 
+       /* Initialize fd field to -1. 0 is a valid fd number */
+       elf->fd = -1;
 
        elf->path = strdup(path);
        if (!elf->path) {
This page took 0.025306 seconds and 4 git commands to generate.