1490026 Unchecked return value
If the function returns an error value, the error value may be mistaken
for a normal value.
In run_test_lttng_uuid_is_equal(): Value returned from a function is not
checked for errors before being used (CWE-252)
Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: Id9558a07ebcc47f5630deed32f5a457ba002bfe6
int ret;
lttng_uuid uuid1, uuid2;
int ret;
lttng_uuid uuid1, uuid2;
- lttng_uuid_from_str(valid_str_1, uuid1);
- lttng_uuid_from_str(valid_str_1, uuid2);
+ ret = lttng_uuid_from_str(valid_str_1, uuid1);
+ assert(ret == 0);
+ ret = lttng_uuid_from_str(valid_str_1, uuid2);
+ assert(ret == 0);
ret = uuid1 == uuid2;
ok(ret == true, "lttng_uuid_is_equal - Compare same UUID, expect success");
ret = uuid1 == uuid2;
ok(ret == true, "lttng_uuid_is_equal - Compare same UUID, expect success");
- lttng_uuid_from_str(valid_str_2, uuid2);
+ ret = lttng_uuid_from_str(valid_str_2, uuid2);
+ assert(ret == 0);
ret = uuid1 == uuid2;
ok(ret == false, "lttng_uuid_is_equal - Compare different UUID, expect failure");
}
ret = uuid1 == uuid2;
ok(ret == false, "lttng_uuid_is_equal - Compare different UUID, expect failure");
}