X-Git-Url: http://git.liburcu.org/?a=blobdiff_plain;f=lttng-filter-validator.c;h=2a5db1198215aabfc1d4e39f77cfc26e0f1b49cf;hb=499ac8be0b08816e44bdc76ce2b8bdd0c64a2909;hp=c479af08153c1d152793f2a4a9260ac7b11b21ed;hpb=c89271d467715e782b76a87c8e26859ec04d9aff;p=lttng-modules.git

diff --git a/lttng-filter-validator.c b/lttng-filter-validator.c
index c479af08..2a5db119 100644
--- a/lttng-filter-validator.c
+++ b/lttng-filter-validator.c
@@ -976,60 +976,30 @@ int validate_instruction_context(struct bytecode_runtime *bytecode,
 		dbg_printk("Validate load field\n");
 		break;
 	}
+
+	/*
+	 * Disallow already specialized bytecode op load field instructions to
+	 * ensure that the received bytecode does not:
+	 *
+	 * - Read user-space memory without proper get_user accessors,
+	 * - Read a memory area larger than the memory targeted by the instrumentation.
+	 */
 	case FILTER_OP_LOAD_FIELD_S8:
-	{
-		dbg_printk("Validate load field s8\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_S16:
-	{
-		dbg_printk("Validate load field s16\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_S32:
-	{
-		dbg_printk("Validate load field s32\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_S64:
-	{
-		dbg_printk("Validate load field s64\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_U8:
-	{
-		dbg_printk("Validate load field u8\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_U16:
-	{
-		dbg_printk("Validate load field u16\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_U32:
-	{
-		dbg_printk("Validate load field u32\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_U64:
-	{
-		dbg_printk("Validate load field u64\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_STRING:
-	{
-		dbg_printk("Validate load field string\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_SEQUENCE:
-	{
-		dbg_printk("Validate load field sequence\n");
-		break;
-	}
 	case FILTER_OP_LOAD_FIELD_DOUBLE:
 	{
-		dbg_printk("Validate load field double\n");
-		break;
+		dbg_printk("Validate load field, reject specialized load instruction (%d)\n",
+				(int) opcode);
+		ret = -EINVAL;
+		goto end;
 	}
 
 	case FILTER_OP_GET_SYMBOL: