X-Git-Url: http://git.liburcu.org/?a=blobdiff_plain;f=lttng-abi.c;h=ca943791fdc9f2875cfd6c9412c2686bd22e85ff;hb=59a49244b2cd0e06b15457a570ea7c5b3f0a5a53;hp=9d3f74240724ca72f5c4db1b93c4d74837b99848;hpb=3aed4dca825a63757a3c95b9d41019660f83e02d;p=lttng-modules.git diff --git a/lttng-abi.c b/lttng-abi.c index 9d3f7424..ca943791 100644 --- a/lttng-abi.c +++ b/lttng-abi.c @@ -419,8 +419,8 @@ int lttng_abi_create_channel(struct file *session_file, transport_name = ""; break; } - if (atomic_long_add_unless(&session_file->f_count, - 1, INT_MAX) == INT_MAX) { + if (!atomic_long_add_unless(&session_file->f_count, 1, LONG_MAX)) { + ret = -EOVERFLOW; goto refcount_error; } /* @@ -1072,8 +1072,7 @@ int lttng_abi_create_event(struct file *channel_file, goto file_error; } /* The event holds a reference on the channel */ - if (atomic_long_add_unless(&channel_file->f_count, - 1, INT_MAX) == INT_MAX) { + if (!atomic_long_add_unless(&channel_file->f_count, 1, LONG_MAX)) { ret = -EOVERFLOW; goto refcount_error; } @@ -1472,7 +1471,9 @@ long lttng_event_ioctl(struct file *file, unsigned int cmd, unsigned long arg) return lttng_enabler_attach_bytecode(enabler, (struct lttng_kernel_filter_bytecode __user *) arg); } - + default: + WARN_ON_ONCE(1); + return -ENOSYS; } case LTTNG_KERNEL_ADD_CALLSITE: switch (*evtype) {