X-Git-Url: http://git.liburcu.org/?a=blobdiff_plain;f=lttctl%2Fltt-armall.sh;h=9b740d1cfd9b0e7dc85112f79000a8ae18ccccbc;hb=7ce719c077ee09d91889d3534164d8a96d152d25;hp=7771505f6d3d494d2cf401191f0060ad3630d1a5;hpb=045880fb3602540472b3760832a73b431514bb7f;p=ltt-control.git

diff --git a/lttctl/ltt-armall.sh b/lttctl/ltt-armall.sh
index 7771505..9b740d1 100755
--- a/lttctl/ltt-armall.sh
+++ b/lttctl/ltt-armall.sh
@@ -1,4 +1,3 @@
-#!/bin/bash
 # Copyright (C) 2009 Benjamin Poirier
 
 # This program is free software; you can redistribute it and/or modify
@@ -15,7 +14,7 @@
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-DEBUGFSROOT=$(grep ^debugfs /proc/mounts | head -1 | awk '{print $2}')
+DEBUGFSROOT=$(grep ^debugfs /proc/mounts | head -n 1 | awk '{print $2}')
 MARKERSROOT=${DEBUGFSROOT}/ltt/markers
 
 usage () {
@@ -31,18 +30,18 @@ usage () {
 	echo "" > /dev/stderr
 }
 
-if [ ! "$DEBUGFSROOT" ]; then
+if [ ! "${DEBUGFSROOT}" ]; then
 	echo "Error: debugfs not mounted" > /dev/stderr
 	exit 1;
 fi
 
-if [ ! -d "$MARKERSROOT" ]; then
+if [ ! -d "${MARKERSROOT}" ]; then
 	echo "Error: LTT trace controller not found (did you compile and load LTTng?)" > /dev/stderr
 	exit 1;
 fi
 
 while getopts "lnqh" options; do
-	case $options in
+	case ${options} in
 		l) LOCKING="0";;
 		n) NETWORK="0";;
 		q) QUIET="0";;
@@ -52,20 +51,20 @@ while getopts "lnqh" options; do
 			exit 1;;
 	esac
 done
-shift $(($OPTIND - 1))
+shift $((${OPTIND} - 1))
 
 
-if [ ! $LOCKING ]; then
+if [ ! ${LOCKING} ]; then
 	TESTS="${TESTS} -name lockdep -prune -o -name locking -prune -o"
 fi
 
-if [ ! $NETWORK ]; then
+if [ ! ${NETWORK} ]; then
 	TESTS="${TESTS} -path '*/net/*_extended' -prune -o"
 fi
 
-while read -r -d $'\0' marker; do
-	if [ ! $QUIET ]; then
+(eval "find '${MARKERSROOT}' ${TESTS} -name metadata -prune -o -name enable -print0") | while read -r -d $'\0' marker; do
+	if [ ! ${QUIET} ]; then
 		echo "Connecting ${marker%/enable}"
 	fi
-	echo 1 > $marker
-done < <(eval "find '$MARKERSROOT' $TESTS -name metadata -prune -o -name enable -print0")
+	echo 1 > ${marker}
+done