X-Git-Url: http://git.liburcu.org/?a=blobdiff_plain;f=liblttng-ust%2Fcompat.h;h=7f0f5027ba6c9a619912fdef33cd866954b19f96;hb=6ba6fd60507f8e045bdc4f1be14e9d99c6a15f7f;hp=69761880e125fbff0504320697c22203180b7d97;hpb=0db3d6ee9be2906d02955fedee802338bcfaef3a;p=lttng-ust.git

diff --git a/liblttng-ust/compat.h b/liblttng-ust/compat.h
index 69761880..7f0f5027 100644
--- a/liblttng-ust/compat.h
+++ b/liblttng-ust/compat.h
@@ -1,28 +1,21 @@
-#ifndef _UST_COMPAT_H
-#define _UST_COMPAT_H
-
 /*
+ * SPDX-License-Identifier: LGPL-2.1-only
+ *
  * Copyright (C) 2011 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
  * Copyright (C) 2016 Raphaël Beamonte <raphael.beamonte@gmail.com>
  * Copyright (C) 2020 Michael Jeanson <mjeanson@efficios.com>
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; only
- * version 2.1 of the License.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#ifndef _UST_COMPAT_H
+#define _UST_COMPAT_H
+
 #include <pthread.h>
 #include <errno.h>
+#include <string.h>
+
+#ifdef __FreeBSD__
+#include <pthread_np.h>
+#endif
 
 #include <lttng/ust-abi.h>
 
@@ -33,35 +26,67 @@
 static inline
 int lttng_pthread_setname_np(const char *name)
 {
+	/*
+	 * Some implementations don't error out, replicate this behavior for
+	 * consistency.
+	 */
+	if (strnlen(name, LTTNG_UST_ABI_PROCNAME_LEN) >= LTTNG_UST_ABI_PROCNAME_LEN) {
+		return ERANGE;
+	}
+
 	return pthread_setname_np(pthread_self(), name);
 }
+#elif defined(HAVE_PTHREAD_SETNAME_NP_WITHOUT_TID)
+static inline
+int lttng_pthread_setname_np(const char *name)
+{
+	return pthread_setname_np(name);
+}
+#elif defined(HAVE_PTHREAD_SET_NAME_NP_WITH_TID)
 
 static inline
-int lttng_pthread_getname_np(char *name, size_t len)
+int lttng_pthread_setname_np(const char *name)
 {
-	return pthread_getname_np(pthread_self(), name, len);
+	/* Replicate pthread_setname_np's behavior */
+	if (strnlen(name, LTTNG_UST_ABI_PROCNAME_LEN) >= LTTNG_UST_ABI_PROCNAME_LEN) {
+		return ERANGE;
+	}
+
+	pthread_set_name_np(pthread_self(), name);
+	return 0;
 }
-#elif defined(HAVE_PTHREAD_SETNAME_NP_WITHOUT_TID)
+#elif defined(__linux__)
+
+/* Fallback on prtctl on Linux */
+#include <sys/prctl.h>
+
 static inline
 int lttng_pthread_setname_np(const char *name)
 {
-	return pthread_setname_np(name);
+	/* Replicate pthread_setname_np's behavior */
+	if (strnlen(name, LTTNG_UST_ABI_PROCNAME_LEN) >= LTTNG_UST_ABI_PROCNAME_LEN) {
+		return ERANGE;
+	}
+	return prctl(PR_SET_NAME, name, 0, 0, 0);
 }
+#else
+#error "Please add pthread set name support for your OS."
+#endif
 
+
+#if defined(HAVE_PTHREAD_GETNAME_NP_WITH_TID)
 static inline
 int lttng_pthread_getname_np(char *name, size_t len)
 {
-	return pthread_getname_np(name, len);
+	return pthread_getname_np(pthread_self(), name, len);
 }
-#elif defined(HAVE_PTHREAD_SET_NAME_NP_WITH_TID)
-
-#include <pthread_np.h>
+#elif defined(HAVE_PTHREAD_GETNAME_NP_WITHOUT_TID)
 static inline
-int lttng_pthread_setname_np(const char *name)
+int lttng_pthread_getname_np(char *name, size_t len)
 {
-	pthread_set_name_np(pthread_self(), name);
-	return 0;
+	return pthread_getname_np(name, len);
 }
+#elif defined(HAVE_PTHREAD_GET_NAME_NP_WITH_TID)
 
 static inline
 int lttng_pthread_getname_np(char *name, size_t len)
@@ -74,12 +99,6 @@ int lttng_pthread_getname_np(char *name, size_t len)
 /* Fallback on prtctl on Linux */
 #include <sys/prctl.h>
 
-static inline
-int lttng_pthread_setname_np(const char *name)
-{
-	return prctl(PR_SET_NAME, name, 0, 0, 0);
-}
-
 static inline
 int lttng_pthread_getname_np(char *name, size_t len)
 {
@@ -87,7 +106,7 @@ int lttng_pthread_getname_np(char *name, size_t len)
 }
 
 #else
-#error "Please add pthread name support for your OS."
+#error "Please add pthread get name support for your OS."
 #endif
 
 /*