* is in hexadecimal and can be 1 to 9 if it's in decimal.
*/
if (*s_hex == '\0' || !isdigit(*s_hex)) {
- ERR("Invalid probe description %s", s_hex);
+ ERR("Invalid probe description `%s`", s_hex);
ret = CMD_ERROR;
goto end;
}
const char *exclusion =
(const char *) lttng_dynamic_pointer_array_get_pointer(exclusions, i);
- strcat(ret, "\"");
+ strcat(ret, "`");
strcat(ret, exclusion);
- strcat(ret, "\"");
+ strcat(ret, "`");
if (i != count - 1) {
strcat(ret, ", ");
}
if (*x == '*') {
/* Event is a subset of the excluder */
- ERR("Event %s: %s excludes all events from %s", pattern, exclusion, pattern);
+ ERR("Exclusion pattern `%s` excludes all events from `%s`",
+ exclusion,
+ pattern);
goto error;
}
end:
if (warn) {
- WARN("Event %s: %s does not exclude any events from %s",
- pattern,
+ WARN("Exclusion pattern `%s` does not exclude any event from `%s`",
exclusion,
pattern);
}
if (opt_kernel) {
if (opt_loglevel) {
- WARN("Kernel loglevels are not supported.");
+ WARN("Kernel log levels are not supported");
}
}
case LTTNG_DOMAIN_JUL:
case LTTNG_DOMAIN_LOG4J:
case LTTNG_DOMAIN_PYTHON:
- ERR("Event name exclusions are not yet implemented for %s events",
+ ERR("Event name exclusions are not supported for %s event rules",
lttng_domain_type_str(dom.type));
ret = CMD_ERROR;
goto error;
case LTTNG_EVENT_PROBE:
case LTTNG_EVENT_USERSPACE_PROBE:
case LTTNG_EVENT_FUNCTION:
- ERR("Filter expressions are not supported for %s events",
+ ERR("Filter expressions are not supported for %s event rules",
get_event_type_str((lttng_event_type) opt_event_type));
ret = CMD_ERROR;
goto error;
}
}
- if (opt_enable_all) {
- /* Default setup for enable all */
- if (opt_kernel) {
- ev->type = (lttng_event_type) opt_event_type;
- strcpy(ev->name, "*");
- /* kernel loglevels not implemented */
- ev->loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;
- } else {
- ev->type = LTTNG_EVENT_TRACEPOINT;
- strcpy(ev->name, "*");
- ev->loglevel_type = (lttng_loglevel_type) opt_loglevel_type;
- if (opt_loglevel) {
- int name_search_ret;
-
- LTTNG_ASSERT(opt_userspace || opt_jul || opt_log4j || opt_python);
-
- if (opt_userspace) {
- enum lttng_loglevel loglevel;
-
- name_search_ret =
- loglevel_name_to_value(opt_loglevel, &loglevel);
- ev->loglevel = (int) loglevel;
- } else if (opt_jul) {
- enum lttng_loglevel_jul loglevel;
-
- name_search_ret =
- loglevel_jul_name_to_value(opt_loglevel, &loglevel);
- ev->loglevel = (int) loglevel;
- } else if (opt_log4j) {
- enum lttng_loglevel_log4j loglevel;
-
- name_search_ret = loglevel_log4j_name_to_value(opt_loglevel,
- &loglevel);
- ev->loglevel = (int) loglevel;
- } else {
- /* python domain. */
- enum lttng_loglevel_python loglevel;
-
- name_search_ret = loglevel_python_name_to_value(
- opt_loglevel, &loglevel);
- ev->loglevel = (int) loglevel;
- }
-
- if (name_search_ret == -1) {
- ERR("Unknown loglevel %s", opt_loglevel);
- ret = -LTTNG_ERR_INVALID;
- goto error;
- }
- } else {
- LTTNG_ASSERT(opt_userspace || opt_jul || opt_log4j || opt_python);
- if (opt_userspace) {
- ev->loglevel = -1;
- } else if (opt_jul) {
- ev->loglevel = LTTNG_LOGLEVEL_JUL_ALL;
- } else if (opt_log4j) {
- ev->loglevel = LTTNG_LOGLEVEL_LOG4J_ALL;
- } else if (opt_python) {
- ev->loglevel = LTTNG_LOGLEVEL_PYTHON_DEBUG;
- }
- }
- }
-
- if (opt_exclude) {
- ret = create_exclusion_list_and_validate("*", opt_exclude, &exclusions);
- if (ret) {
- ret = CMD_ERROR;
- goto error;
- }
-
- ev->exclusion = 1;
- warn_on_truncated_exclusion_names(&exclusions, &warn);
- }
- if (!opt_filter) {
- ret = lttng_enable_event_with_exclusions(
- handle,
- ev,
- channel_name,
- nullptr,
- lttng_dynamic_pointer_array_get_count(&exclusions),
- (char **) exclusions.array.buffer.data);
- if (ret < 0) {
- switch (-ret) {
- case LTTNG_ERR_KERN_EVENT_EXIST:
- WARN("Kernel events already enabled (channel %s, session %s)",
- print_channel_name(channel_name),
- session_name.c_str());
- warn = 1;
- break;
- case LTTNG_ERR_TRACE_ALREADY_STARTED:
- {
- const char *msg =
- "The command tried to enable an event in a new domain for a session that has already been started once.";
- ERR("Events: %s (channel %s, session %s)",
- msg,
- print_channel_name(channel_name),
- session_name.c_str());
- error = 1;
- break;
- }
- default:
- ERR("Events: %s (channel %s, session %s)",
- lttng_strerror(ret),
- ret == -LTTNG_ERR_NEED_CHANNEL_NAME ?
- print_raw_channel_name(channel_name) :
- print_channel_name(channel_name),
- session_name.c_str());
- error = 1;
- break;
- }
- goto end;
- }
-
- switch (opt_event_type) {
- case LTTNG_EVENT_TRACEPOINT:
- if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) {
- char *exclusion_string = print_exclusions(&exclusions);
-
- if (!exclusion_string) {
- PERROR("Cannot allocate exclusion_string");
- error = 1;
- goto end;
- }
- MSG("All %s tracepoints%s are enabled in channel %s for loglevel %s",
- lttng_domain_type_str(dom.type),
- exclusion_string,
- print_channel_name(channel_name),
- opt_loglevel);
- free(exclusion_string);
- } else {
- char *exclusion_string = print_exclusions(&exclusions);
-
- if (!exclusion_string) {
- PERROR("Cannot allocate exclusion_string");
- error = 1;
- goto end;
- }
- MSG("All %s tracepoints%s are enabled in channel %s",
- lttng_domain_type_str(dom.type),
- exclusion_string,
- print_channel_name(channel_name));
- free(exclusion_string);
- }
- break;
- case LTTNG_EVENT_SYSCALL:
- if (opt_kernel) {
- MSG("All %s system calls are enabled in channel %s",
- lttng_domain_type_str(dom.type),
- print_channel_name(channel_name));
- }
- break;
- case LTTNG_EVENT_ALL:
- if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) {
- char *exclusion_string = print_exclusions(&exclusions);
-
- if (!exclusion_string) {
- PERROR("Cannot allocate exclusion_string");
- error = 1;
- goto end;
- }
- MSG("All %s events%s are enabled in channel %s for loglevel %s",
- lttng_domain_type_str(dom.type),
- exclusion_string,
- print_channel_name(channel_name),
- opt_loglevel);
- free(exclusion_string);
- } else {
- char *exclusion_string = print_exclusions(&exclusions);
-
- if (!exclusion_string) {
- PERROR("Cannot allocate exclusion_string");
- error = 1;
- goto end;
- }
- MSG("All %s events%s are enabled in channel %s",
- lttng_domain_type_str(dom.type),
- exclusion_string,
- print_channel_name(channel_name));
- free(exclusion_string);
- }
- break;
- default:
- /*
- * We should not be here since lttng_enable_event should have
- * failed on the event type.
- */
- goto error;
- }
- }
-
- if (opt_filter) {
- command_ret = lttng_enable_event_with_exclusions(
- handle,
- ev,
- channel_name,
- opt_filter,
- lttng_dynamic_pointer_array_get_count(&exclusions),
- (char **) exclusions.array.buffer.data);
- if (command_ret < 0) {
- switch (-command_ret) {
- case LTTNG_ERR_FILTER_EXIST:
- WARN("Filter on all events is already enabled"
- " (channel %s, session %s)",
- print_channel_name(channel_name),
- session_name.c_str());
- warn = 1;
- break;
- case LTTNG_ERR_TRACE_ALREADY_STARTED:
- {
- const char *msg =
- "The command tried to enable an event in a new domain for a session that has already been started once.";
- ERR("All events: %s (channel %s, session %s, filter \'%s\')",
- msg,
- print_channel_name(channel_name),
- session_name.c_str(),
- opt_filter);
- error = 1;
- break;
- }
- default:
- ERR("All events: %s (channel %s, session %s, filter \'%s\')",
- lttng_strerror(command_ret),
- command_ret == -LTTNG_ERR_NEED_CHANNEL_NAME ?
- print_raw_channel_name(channel_name) :
- print_channel_name(channel_name),
- session_name.c_str(),
- opt_filter);
- error = 1;
- break;
- }
- error_holder = command_ret;
- } else {
- ev->filter = 1;
- MSG("Filter '%s' successfully set", opt_filter);
- }
- }
-
- if (lttng_opt_mi) {
- /* The wildcard * is used for kernel and ust domain to
- * represent ALL. We copy * in event name to force the wildcard use
- * for kernel domain
- *
- * Note: this is strictly for semantic and printing while in
- * machine interface mode.
- */
- strcpy(ev->name, "*");
-
- /* If we reach here the events are enabled */
- if (!error && !warn) {
- ev->enabled = 1;
- } else {
- ev->enabled = 0;
- success = 0;
- }
- ret = mi_lttng_event(writer.get(), ev, 1, handle->domain.type);
- if (ret) {
- ret = CMD_ERROR;
- goto error;
- }
-
- /* print exclusion */
- ret = mi_print_exclusion(&exclusions);
- if (ret) {
- ret = CMD_ERROR;
- goto error;
- }
-
- /* Success ? */
- ret = mi_lttng_writer_write_element_bool(
- writer.get(), mi_lttng_element_command_success, success);
- if (ret) {
- ret = CMD_ERROR;
- goto error;
- }
-
- /* Close event element */
- ret = mi_lttng_writer_close_element(writer.get());
- if (ret) {
- ret = CMD_ERROR;
- goto error;
- }
- }
-
- goto end;
- }
-
- /* Strip event list */
for (const auto& pattern : patterns) {
/* Copy name and type of the event */
strncpy(ev->name, pattern.c_str(), LTTNG_SYMBOL_NAME_LEN);
/* Kernel tracer action */
if (opt_kernel) {
- DBG_FMT("Enabling kernel event: pattern=`{}`, channel_name=`{}`",
+ DBG_FMT("Enabling kernel event rule: pattern=`{}`, channel_name=`{}`",
pattern,
print_channel_name(channel_name));
break;
case CMD_ERROR:
default:
- ERR("Unable to parse userspace probe options");
+ ERR("Unable to parse user space probe options");
break;
}
goto error;
/* kernel loglevels not implemented */
ev->loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;
} else if (opt_userspace) { /* User-space tracer action */
- DBG("Enabling UST event %s for channel %s, loglevel %s",
- pattern.c_str(),
- print_channel_name(channel_name),
- opt_loglevel ?: "<all>");
+ DBG_FMT("Enabling user space event rule: pattern=`{}`, channel_name=`{}`, log_level=`{}`",
+ pattern.c_str(),
+ print_channel_name(channel_name),
+ opt_loglevel ?: "all");
switch (opt_event_type) {
case LTTNG_EVENT_ALL: /* Default behavior is tracepoint */
case LTTNG_EVENT_SYSCALL:
case LTTNG_EVENT_USERSPACE_PROBE:
default:
- ERR("Event type not available for user-space tracing");
+ ERR("Instrumentation point type not supported for the %s domain",
+ lttng_domain_type_str(dom.type));
ret = CMD_UNSUPPORTED;
goto error;
}
loglevel_name_to_value(opt_loglevel, &loglevel);
if (name_search_ret == -1) {
- ERR("Unknown loglevel %s", opt_loglevel);
+ ERR("Unknown log level `%s`", opt_loglevel);
ret = -LTTNG_ERR_INVALID;
goto error;
}
} else if (opt_jul || opt_log4j || opt_python) {
if (opt_event_type != LTTNG_EVENT_ALL &&
opt_event_type != LTTNG_EVENT_TRACEPOINT) {
- ERR("Event type not supported for domain.");
+ ERR("Instrumentation point type not supported for the %s domain",
+ lttng_domain_type_str(dom.type));
ret = CMD_UNSUPPORTED;
goto error;
}
}
if (name_search_ret) {
- ERR("Unknown loglevel %s", opt_loglevel);
+ ERR("Unknown log level `%s`", opt_loglevel);
ret = -LTTNG_ERR_INVALID;
goto error;
}
}
if (!opt_filter) {
- char *exclusion_string;
-
command_ret = lttng_enable_event_with_exclusions(
handle,
ev,
nullptr,
lttng_dynamic_pointer_array_get_count(&exclusions),
(char **) exclusions.array.buffer.data);
- exclusion_string = print_exclusions(&exclusions);
+
+ auto exclusion_string =
+ lttng::make_unique_wrapper<char, lttng::memory::free>(
+ print_exclusions(&exclusions));
if (!exclusion_string) {
PERROR("Cannot allocate exclusion_string");
error = 1;
goto end;
}
+
if (command_ret < 0) {
/* Turn ret to positive value to handle the positive error code */
switch (-command_ret) {
case LTTNG_ERR_KERN_EVENT_EXIST:
- WARN("Kernel event %s%s already enabled (channel %s, session %s)",
- pattern.c_str(),
- exclusion_string,
+ WARN("Kernel event rule %s%s and attached to channel `%s` is already enabled (session `%s`)",
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") +
+ pattern + std::string("`"))
+ .c_str(),
+ exclusion_string.get(),
print_channel_name(channel_name),
session_name.c_str());
warn = 1;
break;
case LTTNG_ERR_TRACE_ALREADY_STARTED:
{
- const char *msg =
- "The command tried to enable an event in a new domain for a session that has already been started once.";
- ERR("Event %s%s: %s (channel %s, session %s)",
- pattern.c_str(),
- exclusion_string,
- msg,
- print_channel_name(channel_name),
+ ERR("Can't enable an event in a new domain for a session that has already been started once (session `%s`)",
session_name.c_str());
error = 1;
break;
}
case LTTNG_ERR_SDT_PROBE_SEMAPHORE:
- ERR("SDT probes %s guarded by semaphores are not supported (channel %s, session %s)",
+ ERR("Failed to enable event rule with pattern `%s` and attached to channel `%s` as SDT probes guarded by semaphores are not supported (session `%s`)",
pattern.c_str(),
print_channel_name(channel_name),
session_name.c_str());
error = 1;
break;
default:
- ERR("Event %s%s: %s (channel %s, session %s)",
- pattern.c_str(),
- exclusion_string,
- lttng_strerror(command_ret),
+ ERR("Failed to enable event rule %s%s and attached to channel `%s`: %s (session `%s`)",
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") +
+ pattern + std::string("`"))
+ .c_str(),
+ exclusion_string.get(),
command_ret == -LTTNG_ERR_NEED_CHANNEL_NAME ?
print_raw_channel_name(channel_name) :
print_channel_name(channel_name),
+ lttng_strerror(command_ret),
session_name.c_str());
+
+ if (opt_kernel) {
+ print_kernel_tracer_status_error();
+ }
+
error = 1;
break;
}
switch (dom.type) {
case LTTNG_DOMAIN_KERNEL:
case LTTNG_DOMAIN_UST:
- MSG("%s event %s%s created in channel %s",
+ {
+ MSG("Enabled %s event rule %s%s and attached to channel `%s`",
lttng_domain_type_str(dom.type),
- pattern.c_str(),
- exclusion_string,
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") +
+ pattern + std::string("`"))
+ .c_str(),
+ exclusion_string.get(),
print_channel_name(channel_name));
break;
+ }
case LTTNG_DOMAIN_JUL:
case LTTNG_DOMAIN_LOG4J:
case LTTNG_DOMAIN_PYTHON:
* Don't print the default channel
* name for agent domains.
*/
- MSG("%s event %s%s enabled",
+ MSG("Enabled %s event rule %s%s",
lttng_domain_type_str(dom.type),
- pattern.c_str(),
- exclusion_string);
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") +
+ pattern + std::string("`"))
+ .c_str(),
+ exclusion_string.get());
break;
default:
abort();
}
}
- free(exclusion_string);
- }
-
- if (opt_filter) {
- char *exclusion_string;
-
+ } else {
/* Filter present */
ev->filter = 1;
opt_filter,
lttng_dynamic_pointer_array_get_count(&exclusions),
(char **) exclusions.array.buffer.data);
- exclusion_string = print_exclusions(&exclusions);
+
+ auto exclusion_string =
+ lttng::make_unique_wrapper<char, lttng::memory::free>(
+ print_exclusions(&exclusions));
if (!exclusion_string) {
- PERROR("Cannot allocate exclusion_string");
+ PERROR("Failed allocate exclusion string");
error = 1;
goto end;
}
if (command_ret < 0) {
switch (-command_ret) {
case LTTNG_ERR_FILTER_EXIST:
- WARN("Filter on event %s%s is already enabled"
- " (channel %s, session %s)",
- pattern.c_str(),
- exclusion_string,
- print_channel_name(channel_name),
- session_name.c_str());
+ WARN("An event rule %s%s and filter expression `%s` is already attached to channel `%s`",
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") +
+ pattern + std::string("`"))
+ .c_str(),
+ exclusion_string.get(),
+ opt_filter,
+ print_channel_name(channel_name));
warn = 1;
break;
case LTTNG_ERR_TRACE_ALREADY_STARTED:
{
- const char *msg =
- "The command tried to enable an event in a new domain for a session that has already been started once.";
- ERR("Event %s%s: %s (channel %s, session %s, filter \'%s\')",
- ev->name,
- exclusion_string,
- msg,
- print_channel_name(channel_name),
- session_name.c_str(),
- opt_filter);
+ ERR("Can't enable an event in a new domain for a session that has already been started once (session `%s`)",
+ session_name.c_str());
error = 1;
break;
}
default:
- ERR("Event %s%s: %s (channel %s, session %s, filter \'%s\')",
- ev->name,
- exclusion_string,
- lttng_strerror(command_ret),
+ ERR("Failed to enable event rule %s%s, with filter expression `%s`, and attached to channel `%s`: %s (session `%s`)",
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") +
+ pattern + std::string("`"))
+ .c_str(),
+ exclusion_string.get(),
+ opt_filter,
command_ret == -LTTNG_ERR_NEED_CHANNEL_NAME ?
print_raw_channel_name(channel_name) :
print_channel_name(channel_name),
- session_name.c_str(),
- opt_filter);
+ lttng_strerror(command_ret),
+ session_name.c_str());
error = 1;
+
+ if (opt_kernel) {
+ print_kernel_tracer_status_error();
+ }
+
break;
}
- error_holder = command_ret;
+ error_holder = command_ret;
} else {
- MSG("Event %s%s: Filter '%s' successfully set",
- pattern.c_str(),
- exclusion_string,
+ MSG("Enabled %s event rule %s%s and filter expression `%s`",
+ lttng_domain_type_str(dom.type),
+ opt_enable_all ? "matching all events" :
+ (std::string("with pattern `") + pattern +
+ std::string("`"))
+ .c_str(),
+
+ exclusion_string.get(),
opt_filter);
}
- free(exclusion_string);
}
if (lttng_opt_mi) {
{
int ret;
- /* Event name must be a valid globbing pattern to allow exclusions. */
+ /* Event name pattern must be a valid globbing pattern to allow exclusions. */
if (!strutils_is_star_glob_pattern(pattern)) {
- ERR("Event %s: Exclusions can only be used with a globbing pattern", pattern);
+ ERR("Event name pattern must contain wildcard characters to use exclusions");
goto error;
}
const char *leftover = nullptr;
int event_type = -1;
event_rule_patterns patterns;
- std::stringstream event_list_arg_stream(arg_event_list);
auto pc = lttng::make_unique_wrapper<poptContext_s, _poptContextFree_deleter_func>(
poptGetContext(nullptr, argc, argv, long_options, 0));
event_type = opt_event_type;
} else {
if (event_type != opt_event_type) {
- ERR("Multiple event type not supported.");
+ ERR("Only one event type may be enabled at once");
return CMD_ERROR;
}
}
arg_event_list = poptGetArg(pc.get());
if (arg_event_list == nullptr && opt_enable_all == 0) {
- ERR("Missing event name(s).");
+ ERR("Missing event name pattern(s)");
return CMD_ERROR;
}
- for (std::string line; std::getline(event_list_arg_stream, line, ',');) {
- patterns.emplace_back(std::move(line));
+ if (opt_enable_all) {
+ patterns.emplace_back("*");
+ } else {
+ std::stringstream event_list_arg_stream(arg_event_list);
+
+ for (std::string line; std::getline(event_list_arg_stream, line, ',');) {
+ patterns.emplace_back(std::move(line));
+ }
}
leftover = poptGetArg(pc.get());
if (!opt_session_name) {
const auto rc_file_session_name =
- lttng::make_unique_wrapper<char, lttng::free>(get_session_name());
+ lttng::make_unique_wrapper<char, lttng::memory::free>(get_session_name());
if (!rc_file_session_name) {
return CMD_ERROR;
projects / lttng-tools.git / blobdiff