#include <linux/list.h>
#include <linux/mutex.h>
#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/vmalloc.h> /* For vmalloc_sync_all */
#include "ltt-events.h"
static LIST_HEAD(sessions);
struct ltt_session *session;
mutex_lock(&sessions_mutex);
- session = kmalloc(sizeof(struct ltt_session));
+ session = kzalloc(sizeof(struct ltt_session), GFP_KERNEL);
if (!session)
return NULL;
INIT_LIST_HEAD(&session->chan);
+ INIT_LIST_HEAD(&session->events);
list_add(&session->list, &sessions);
mutex_unlock(&sessions_mutex);
return session;
-
-exist:
- mutex_unlock(&sessions_mutex);
- return NULL;
}
-int ltt_session_destroy(struct ltt_session *session)
+void ltt_session_destroy(struct ltt_session *session)
{
struct ltt_channel *chan, *tmpchan;
struct ltt_event *event, *tmpevent;
synchronize_trace(); /* Wait for in-flight events to complete */
end:
mutex_unlock(&sessions_mutex);
- return ret
+ return ret;
}
int ltt_session_stop(struct ltt_session *session)
synchronize_trace(); /* Wait for in-flight events to complete */
end:
mutex_unlock(&sessions_mutex);
- return ret
+ return ret;
+}
+
+static struct ltt_transport *ltt_transport_find(char *name)
+{
+ struct ltt_transport *transport;
+
+ list_for_each_entry(transport, <t_transport_list, node) {
+ if (!strcmp(transport->name, name))
+ return transport;
+ }
+ return NULL;
}
struct ltt_channel *ltt_channel_create(struct ltt_session *session,
unsigned int read_timer_interval)
{
struct ltt_channel *chan;
- struct ltt_transport *transport = NULL, *tran_iter;
+ struct ltt_transport *transport;
char *transport_name;
mutex_lock(&sessions_mutex);
- if (session->active)
+ if (session->active) {
+ printk(KERN_WARNING "LTTng refusing to add channel to active session\n");
goto active; /* Refuse to add channel to active session */
- transport_name = overwrite ? "relay-overwrite" : "relay-discard";
- list_for_each_entry(tran_iter, <t_transport_list, node) {
- if (!strcmp(tran_iter->name, transport_name)) {
- transport = tran_iter;
- break;
- }
}
- if (!transport)
+ transport_name = overwrite ? "relay-overwrite" : "relay-discard";
+ transport = ltt_transport_find(transport_name);
+ if (!transport) {
+ printk(KERN_WARNING "LTTng transport %s not found\n",
+ transport_name);
goto notransport;
- chan = kmalloc(sizeof(struct ltt_channel), GFP_KERNEL);
+ }
+ chan = kzalloc(sizeof(struct ltt_channel), GFP_KERNEL);
if (!chan)
goto nomem;
chan->session = session;
init_waitqueue_head(&chan->notify_wait);
- transport->ops.channel_create(session, buf_addr, subbuf_size,
- num_subbuf, switch_timer_interval,
- read_timer_interval);
+ chan->chan = transport->ops.channel_create("[lttng]", session, buf_addr,
+ subbuf_size, num_subbuf, switch_timer_interval,
+ read_timer_interval);
+ if (!chan->chan)
+ goto create_error;
+ chan->ops = &transport->ops;
list_add(&chan->list, &session->chan);
mutex_unlock(&sessions_mutex);
return chan;
+create_error:
+ kfree(chan);
nomem:
notransport:
active:
/*
* Only used internally at session destruction.
*/
-int _ltt_channel_destroy(struct ltt_channel *chan)
+void _ltt_channel_destroy(struct ltt_channel *chan)
{
- transport->ops.channel_destroy(chan);
+ chan->ops->channel_destroy(chan->chan);
list_del(&chan->list);
kfree(chan);
}
list_for_each_entry(event, &chan->session->events, list)
if (!strcmp(event->name, name))
goto exist;
- event = kmem_cache_zalloc(events_cache, GFP_KERNEL);
+ event = kmem_cache_zalloc(event_cache, GFP_KERNEL);
if (!event)
goto cache_error;
event->name = kmalloc(strlen(name) + 1, GFP_KERNEL);
if (!event->name)
- goto error;
+ goto name_error;
strcpy(event->name, name);
event->chan = chan;
event->probe = probe;
event->filter = filter;
event->id = chan->free_event_id++;
event->itype = itype;
- mutex_unlock(&sessions_mutex);
/* Populate ltt_event structure before tracepoint registration. */
smp_wmb();
switch (itype) {
case INSTRUM_TRACEPOINTS:
ret = tracepoint_probe_register(name, probe, event);
+ if (ret)
+ goto register_error;
break;
default:
WARN_ON_ONCE(1);
}
+ mutex_unlock(&sessions_mutex);
return event;
-error:
- kmem_cache_free(event);
+register_error:
+ kfree(event->name);
+name_error:
+ kmem_cache_free(event_cache, event);
cache_error:
exist:
full:
*/
int _ltt_event_destroy(struct ltt_event *event)
{
+ int ret = -EINVAL;
+
switch (event->itype) {
case INSTRUM_TRACEPOINTS:
- ret = tracepoint_probe_unregister(name, event->probe, event);
+ ret = tracepoint_probe_unregister(event->name, event->probe,
+ event);
+ if (ret)
+ return ret;
break;
default:
WARN_ON_ONCE(1);
}
kfree(event->name);
- kmem_cache_free(event);
+ kmem_cache_free(event_cache, event);
+ return ret;
}
/**
{
int ret;
- events_cache = KMEM_CACHE(ltt_event, 0);
- if (!events_cache)
+ event_cache = KMEM_CACHE(ltt_event, 0);
+ if (!event_cache)
return -ENOMEM;
+ ret = ltt_debugfs_abi_init();
+ if (ret)
+ goto error;
return 0;
+error:
+ kmem_cache_destroy(event_cache);
+ return ret;
}
+module_init(ltt_events_init);
+
static void __exit ltt_events_exit(void)
{
struct ltt_session *session, *tmpsession;
+ ltt_debugfs_abi_exit();
list_for_each_entry_safe(session, tmpsession, &sessions, list)
ltt_session_destroy(session);
- kmem_cache_destroy(events_cache);
+ kmem_cache_destroy(event_cache);
}
+module_exit(ltt_events_exit);
+
MODULE_LICENSE("GPL and additional rights");
MODULE_AUTHOR("Mathieu Desnoyers <mathieu.desnoyers@efficios.com>");
MODULE_DESCRIPTION("LTTng Events");
projects / lttng-modules.git / blobdiff