#include <stdio.h>
#include <fcntl.h>
+#include <string.h>
+#include <dirent.h>
#include <sys/stat.h>
#include <sys/types.h>
-#include <dirent.h>
-#include <linux/errno.h>
+#include <errno.h>
+#include <unistd.h>
// For realpath
#include <limits.h>
#include <ltt/trace.h>
#include <ltt/facility.h>
#include <ltt/event.h>
+#include <ltt/type.h>
#define DIR_NAME_SIZE 256
+#define UNUSED __attribute__((__unused__))
/* set the offset of the fields belonging to the event,
need the information of the archecture */
/* Functions to parse system.xml file (using glib xml parser) */
-static void parser_start_element (GMarkupParseContext *context,
+static void parser_start_element (GMarkupParseContext UNUSED *context,
const gchar *element_name,
const gchar **attribute_names,
const gchar **attribute_values,
}
}
-static void parser_end_element (GMarkupParseContext *context,
- const gchar *element_name,
- gpointer user_data,
- GError **error)
-{
-}
-
-static void parser_characters (GMarkupParseContext *context,
+static void parser_characters (GMarkupParseContext UNUSED *context,
const gchar *text,
- gsize text_len,
+ gsize UNUSED text_len,
gpointer user_data,
- GError **error)
+ GError UNUSED **error)
{
LttSystemDescription* des = (LttSystemDescription* )user_data;
des->description = g_strdup(text);
{
LttTracefile * tf;
struct stat lTDFStat; /* Trace data file status */
- BlockStart a_block_start;
tf = g_new(LttTracefile, 1);
}
// Is the file large enough to contain a trace
- if(lTDFStat.st_size < sizeof(BlockStart) + EVENT_HEADER_SIZE){
+ if(lTDFStat.st_size < (off_t)(sizeof(BlockStart) + EVENT_HEADER_SIZE)){
g_print("The input data file %s does not contain a trace\n", fileName);
g_free(tf->name);
close(tf->fd);
LttTracefile * tf;
LttEvent ev;
LttFacility * f;
- guint16 evId;
void * pos;
FacilityLoad fLoad;
- int i;
+ unsigned int i;
tf = ltt_tracefile_open(t,control_name);
if(!tf) {
}
}
if(i==t->facility_number) {
- g_warning("Facility: %s, checksum: %d is not found\n",
- fLoad.name,fLoad.checksum);
+ g_warning("Facility: %s, checksum: %u is not found",
+ fLoad.name,(unsigned int)fLoad.checksum);
return -1;
}
}else if(ev.event_id == TRACE_BLOCK_START){
}else if(ev.event_id == TRACE_BLOCK_END){
break;
}else {
- g_warning("Not valid facilities trace file\n");
+ g_warning("Not valid facilities trace file");
return -1;
}
}
{
FILE * fp;
char buf[DIR_NAME_SIZE];
- char description[4*DIR_NAME_SIZE];
GMarkupParseContext * context;
GError * error = NULL;
GMarkupParser markup_parser =
{
parser_start_element,
- parser_end_element,
+ NULL,
parser_characters,
NULL, /* passthrough */
NULL /* error */
DIR * dir;
struct dirent *entry;
char * ptr;
- int i,j;
+ unsigned int i,j;
LttFacility * f;
LttEventType * et;
char name[DIR_NAME_SIZE];
*
*When a trace is closed, all the associated facilities, types and fields
*are released as well.
+ */
+
+
+/****************************************************************************
+ * get_absolute_pathname
*
+ * return the unique pathname in the system
+ *
* MD : Fixed this function so it uses realpath, dealing well with
* forgotten cases (.. were not used correctly before).
*
****************************************************************************/
-
void get_absolute_pathname(const char *pathname, char * abs_pathname)
{
- char * ptr, *ptr1;
- size_t size = DIR_NAME_SIZE;
abs_pathname[0] = '\0';
if ( realpath (pathname, abs_pathname) != NULL)
return;
else
{
- // FIXME : Path is wrong, is it ok to return the pathname unmodified ?
+ /* error, return the original path unmodified */
strcpy(abs_pathname, pathname);
return;
}
-
return;
-
}
LttTrace *ltt_trace_open(const char *pathname)
void ltt_trace_close(LttTrace *t)
{
- int i;
+ unsigned int i;
LttTracefile * tf;
LttFacility * f;
unsigned ltt_trace_facility_find(LttTrace *t, char *name, unsigned *position)
{
- int i, count=0;
+ unsigned int i, count=0;
LttFacility * f;
for(i=0;i<t->facility_number;i++){
f = (LttFacility*)g_ptr_array_index(t->facilities, i);
unsigned ltt_trace_eventtype_number(LttTrace *t)
{
- int i;
+ unsigned int i;
unsigned count = 0;
LttFacility * f;
for(i=0;i<t->facility_number;i++){
LttFacility * ltt_trace_facility_by_id(LttTrace * trace, unsigned id)
{
LttFacility * facility;
- int i;
+ unsigned int i;
for(i=0;i<trace->facility_number;i++){
facility = (LttFacility*) g_ptr_array_index(trace->facilities,i);
if(id >= facility->base_id &&
*and a negative value otherwise.
****************************************************************************/
-int ltt_trace_control_tracefile_find(LttTrace *t, char *name)
+int ltt_trace_control_tracefile_find(LttTrace *t, const gchar *name)
{
LttTracefile * tracefile;
- int i;
+ unsigned int i;
for(i=0;i<t->control_tracefile_number;i++){
tracefile = (LttTracefile*)g_ptr_array_index(t->control_tracefiles, i);
if(strcmp(tracefile->name, name)==0)break;
return i;
}
-int ltt_trace_per_cpu_tracefile_find(LttTrace *t, unsigned i)
+/* not really useful. We just have to know that cpu tracefiles
+ * comes before control tracefiles.
+ */
+int ltt_trace_per_cpu_tracefile_find(LttTrace *t, const gchar *name)
{
LttTracefile * tracefile;
- int j, name;
- for(j=0;j<t->per_cpu_tracefile_number;j++){
- tracefile = (LttTracefile*)g_ptr_array_index(t->per_cpu_tracefiles, j);
- name = atoi(tracefile->name);
- if(name == (int)i)break;
+ unsigned int i;
+ for(i=0;i<t->per_cpu_tracefile_number;i++){
+ tracefile = (LttTracefile*)g_ptr_array_index(t->per_cpu_tracefiles, i);
+ if(strcmp(tracefile->name, name)==0)break;
}
- if(j == t->per_cpu_tracefile_number) return -1;
- return j;
+ if(i == t->per_cpu_tracefile_number) return -1;
+ return i;
}
/*****************************************************************************
void ltt_trace_time_span_get(LttTrace *t, LttTime *start, LttTime *end)
{
LttTime startSmall, startTmp, endBig, endTmp;
- int i, j=0;
+ unsigned int i, j=0;
LttTracefile * tf;
for(i=0;i<t->control_tracefile_number;i++){
lttTime = getEventTime(t);
err = ltt_time_compare(lttTime, time);
if(err > 0){
- if(t->which_event==2 || (&t->prev_event_time,&time)<0){
+ if(t->which_event==2 || ltt_time_compare(t->prev_event_time,time)<0){
return;
}else{
updateTracefile(t);
int readFile(int fd, void * buf, size_t size, char * mesg)
{
- ssize_t nbBytes;
- nbBytes = read(fd, buf, size);
- if(nbBytes != size){
- printf("%s\n",mesg);
+ ssize_t nbBytes = read(fd, buf, size);
+
+ if((size_t)nbBytes != size) {
+ if(nbBytes < 0) {
+ perror("Error in readFile : ");
+ } else {
+ g_warning("%s",mesg);
+ }
return EIO;
}
return 0;
int skipEvent(LttTracefile * t)
{
- int evId, err;
+ int evId;
void * evData;
LttEventType * evT;
LttField * rootFld;
projects / lttv.git / blobdiff