Fix: elf: NULL pointer dereference

[lttng-ust.git] / liblttng-ust / lttng-ust-elf.c

diff --git a/liblttng-ust/lttng-ust-elf.c b/liblttng-ust/lttng-ust-elf.c
index 0df70973fd7906f57d32e0289937bcbf861d7d1a..dd50f2b674d689d2be9831536790e064765b8164 100644 (file)
--- a/liblttng-ust/lttng-ust-elf.c
+++ b/liblttng-ust/lttng-ust-elf.c
@@ -405,8 +405,8 @@ int lttng_ust_elf_get_build_id_from_segment(
        struct lttng_ust_elf *elf, uint8_t **build_id, size_t *length,
        uint64_t offset, uint64_t segment_end, int *found)
 {
-       uint8_t *_build_id;
-       size_t _length;
+       uint8_t *_build_id = NULL;      /* Silence old gcc warning. */
+       size_t _length = 0;             /* Silence old gcc warning. */
        int _found = 0;
 
        while (offset < segment_end) {
@@ -452,7 +452,7 @@ int lttng_ust_elf_get_build_id_from_segment(
 
                _length = nhdr.n_descsz;
                _build_id = zmalloc(sizeof(uint8_t) * _length);
-               if (!build_id) {
+               if (!_build_id) {
                        goto error;
                }
 
@@ -496,8 +496,8 @@ int lttng_ust_elf_get_build_id(struct lttng_ust_elf *elf, uint8_t **build_id,
                        size_t *length, int *found)
 {
        uint16_t i;
-       uint8_t *_build_id;
-       size_t _length;
+       uint8_t *_build_id = NULL;      /* Silence old gcc warning. */
+       size_t _length = 0;             /* Silence old gcc warning. */
        int _found = 0;
 
        if (!elf || !build_id || !length || !found) {
@@ -507,7 +507,7 @@ int lttng_ust_elf_get_build_id(struct lttng_ust_elf *elf, uint8_t **build_id,
        for (i = 0; i < elf->ehdr->e_phnum; ++i) {
                uint64_t offset, segment_end;
                struct lttng_ust_elf_phdr *phdr;
-               int ret;
+               int ret = 0;
 
                phdr = lttng_ust_elf_get_phdr(elf, i);
                if (!phdr) {
@@ -561,10 +561,10 @@ int lttng_ust_elf_get_debug_link_from_section(struct lttng_ust_elf *elf,
                                        struct lttng_ust_elf_shdr *shdr)
 {
        int _found = 0;
-       char *_filename;
+       char *_filename = NULL;         /* Silence old gcc warning. */
        size_t filename_len;
        char *section_name = NULL;
-       uint32_t _crc;
+       uint32_t _crc = 0;              /* Silence old gcc warning. */
 
        if (!elf || !filename || !crc || !found || !shdr) {
                goto error;
@@ -645,8 +645,8 @@ int lttng_ust_elf_get_debug_link(struct lttng_ust_elf *elf, char **filename,
        int ret;
        uint16_t i;
        int _found = 0;
-       char *_filename;
-       uint32_t _crc;
+       char *_filename = NULL;         /* Silence old gcc warning. */
+       uint32_t _crc = 0;              /* Silence old gcc warning. */
 
        if (!elf || !filename || !crc || !found) {
                goto error;