projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: Use PERROR all across lttng-tools, never make it quiet
[lttng-tools.git]
/
src
/
common
/
sessiond-comm
/
sessiond-comm.c
diff --git
a/src/common/sessiond-comm/sessiond-comm.c
b/src/common/sessiond-comm/sessiond-comm.c
index 0c29003a6267a382b204a6f277a9d0a1468ad182..8a5ff1d3f10520efb26bef784dc7847fd7fba033 100644
(file)
--- a/
src/common/sessiond-comm/sessiond-comm.c
+++ b/
src/common/sessiond-comm/sessiond-comm.c
@@
-29,6
+29,7
@@
#include <errno.h>
#include <common/defaults.h>
#include <errno.h>
#include <common/defaults.h>
+#include <common/error.h>
#include "sessiond-comm.h"
#include "sessiond-comm.h"
@@
-141,12
+142,11
@@
const char *lttcomm_get_readable_code(enum lttcomm_return_code code)
int lttcomm_connect_unix_sock(const char *pathname)
{
struct sockaddr_un sun;
int lttcomm_connect_unix_sock(const char *pathname)
{
struct sockaddr_un sun;
- int fd;
- int ret;
+ int fd, ret, closeret;
fd = socket(PF_UNIX, SOCK_STREAM, 0);
if (fd < 0) {
fd = socket(PF_UNIX, SOCK_STREAM, 0);
if (fd < 0) {
-
perror
("socket");
+
PERROR
("socket");
ret = fd;
goto error;
}
ret = fd;
goto error;
}
@@
-168,7
+168,10
@@
int lttcomm_connect_unix_sock(const char *pathname)
return fd;
error_connect:
return fd;
error_connect:
- close(fd);
+ closeret = close(fd);
+ if (closeret) {
+ PERROR("close");
+ }
error:
return ret;
}
error:
return ret;
}
@@
-186,7
+189,7
@@
int lttcomm_accept_unix_sock(int sock)
/* Blocking call */
new_fd = accept(sock, (struct sockaddr *) &sun, &len);
if (new_fd < 0) {
/* Blocking call */
new_fd = accept(sock, (struct sockaddr *) &sun, &len);
if (new_fd < 0) {
-
perror
("accept");
+
PERROR
("accept");
}
return new_fd;
}
return new_fd;
@@
-204,7
+207,7
@@
int lttcomm_create_unix_sock(const char *pathname)
/* Create server socket */
if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) {
/* Create server socket */
if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) {
-
perror
("socket");
+
PERROR
("socket");
goto error;
}
goto error;
}
@@
-217,7
+220,7
@@
int lttcomm_create_unix_sock(const char *pathname)
(void) unlink(pathname);
ret = bind(fd, (struct sockaddr *) &sun, sizeof(sun));
if (ret < 0) {
(void) unlink(pathname);
ret = bind(fd, (struct sockaddr *) &sun, sizeof(sun));
if (ret < 0) {
-
perror
("bind");
+
PERROR
("bind");
goto error;
}
goto error;
}
@@
-236,7
+239,7
@@
int lttcomm_listen_unix_sock(int sock)
ret = listen(sock, LTTNG_SESSIOND_COMM_MAX_LISTEN);
if (ret < 0) {
ret = listen(sock, LTTNG_SESSIOND_COMM_MAX_LISTEN);
if (ret < 0) {
-
perror
("listen");
+
PERROR
("listen");
}
return ret;
}
return ret;
@@
-263,7
+266,7
@@
ssize_t lttcomm_recv_unix_sock(int sock, void *buf, size_t len)
ret = recvmsg(sock, &msg, MSG_WAITALL);
if (ret < 0) {
ret = recvmsg(sock, &msg, MSG_WAITALL);
if (ret < 0) {
-
perror
("recvmsg");
+
PERROR
("recvmsg");
}
return ret;
}
return ret;
@@
-289,7
+292,7
@@
ssize_t lttcomm_send_unix_sock(int sock, void *buf, size_t len)
ret = sendmsg(sock, &msg, 0);
if (ret < 0) {
ret = sendmsg(sock, &msg, 0);
if (ret < 0) {
-
perror
("sendmsg");
+
PERROR
("sendmsg");
}
return ret;
}
return ret;
@@
-300,15
+303,18
@@
ssize_t lttcomm_send_unix_sock(int sock, void *buf, size_t len)
*/
int lttcomm_close_unix_sock(int sock)
{
*/
int lttcomm_close_unix_sock(int sock)
{
- int ret;
+ int ret
, closeret
;
/* Shutdown receptions and transmissions */
ret = shutdown(sock, SHUT_RDWR);
if (ret < 0) {
/* Shutdown receptions and transmissions */
ret = shutdown(sock, SHUT_RDWR);
if (ret < 0) {
-
perror
("shutdown");
+
PERROR
("shutdown");
}
}
- close(sock);
+ closeret = close(sock);
+ if (closeret) {
+ PERROR("close");
+ }
return ret;
}
return ret;
}
@@
-351,7
+357,7
@@
ssize_t lttcomm_send_fds_unix_sock(int sock, int *fds, size_t nb_fd)
ret = sendmsg(sock, &msg, 0);
if (ret < 0) {
ret = sendmsg(sock, &msg, 0);
if (ret < 0) {
-
perror
("sendmsg");
+
PERROR
("sendmsg");
}
return ret;
}
}
return ret;
}
@@
-386,7
+392,7
@@
ssize_t lttcomm_recv_fds_unix_sock(int sock, int *fds, size_t nb_fd)
ret = recvmsg(sock, &msg, 0);
if (ret < 0) {
ret = recvmsg(sock, &msg, 0);
if (ret < 0) {
-
perror
("recvmsg fds");
+
PERROR
("recvmsg fds");
goto end;
}
if (ret != 1) {
goto end;
}
if (ret != 1) {
@@
-460,7
+466,7
@@
ssize_t lttcomm_send_creds_unix_sock(int sock, void *buf, size_t len)
ret = sendmsg(sock, &msg, 0);
if (ret < 0) {
ret = sendmsg(sock, &msg, 0);
if (ret < 0) {
-
perror
("sendmsg");
+
PERROR
("sendmsg");
}
return ret;
}
return ret;
@@
-500,7
+506,7
@@
ssize_t lttcomm_recv_creds_unix_sock(int sock, void *buf, size_t len,
ret = recvmsg(sock, &msg, 0);
if (ret < 0) {
ret = recvmsg(sock, &msg, 0);
if (ret < 0) {
-
perror
("recvmsg fds");
+
PERROR
("recvmsg fds");
goto end;
}
goto end;
}
@@
-547,7
+553,7
@@
int lttcomm_setsockopt_creds_unix_sock(int sock)
/* Set socket for credentials retrieval */
ret = setsockopt(sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on));
if (ret < 0) {
/* Set socket for credentials retrieval */
ret = setsockopt(sock, SOL_SOCKET, SO_PASSCRED, &on, sizeof(on));
if (ret < 0) {
-
perror
("setsockopt creds unix sock");
+
PERROR
("setsockopt creds unix sock");
}
return ret;
}
return ret;
This page took
0.025906 seconds
and
4
git commands to generate.